Merged
Conversation
- project.app_data_storage - replaces the useAppData property form the config.json file - user.name - replaces the name properti in config file created by 'regolith init' - resolvers - is a list of URLs to 'resolver.json' files. This property is only partially implemented. Currently it only uses the first item from the list or the default value if the 'config.toml' doesn't specify any.
…er merging the CLI changes.
Member
Author
|
OUTDATED !!! I think the help message is a nice summary of what the config command currently does: |
…code in main_functions.go a little.
…using the direct URL.
Nusiq
commented
Nov 5, 2022
| muzzammil.xyz/jsonc v1.0.0 | ||
| ) | ||
|
|
||
| replace github.com/hashicorp/go-getter => github.com/arikkfir/go-getter v1.6.3-0.20220803164326-281b7670b734 |
Member
Author
There was a problem hiding this comment.
We're using the unofficial version of go-getter here. We have to wait until this PR will be merged:
Member
Author
|
I removed the |
Member
Author
|
This PR closes #221 |
stirante
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit added basic user_config reader:
project.app_data_storage- replaces the useAppData property form the config.json fileuser.name- replaces the name property in config file created by 'regolith init'resolvers- is a list of URLs to 'resolver.json' files. This property is only partially implemented. Currently it only uses the first item from the list or the default value if the 'config.toml' doesn't specify any.