fix: useless request api-depot #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
En regardant les log datadog je me suis apercu qu'on avait l'erreur
Mes Adresses Api Out error { code: 404, message: 'L’identifiant de l’habilitation est invalide' }des milliers de fois par seconde au heure de pointe (exemple en image)Cette erreurs vient lorsque on appelle la route /habilitations/undefined, ce qui est le cas pour toutes les BAL de mes-adresses qui sont en brouillon par exemple.
Lorsque l'on arrive sur la page principal de mes-adresse, cela lance une requète /habilitation pour chaque bals, pour toutes celle qui sont en brouillons cela lance une /habilitations/undefined et donc le logs d'erreur.
Cela rend les log quasi illisible et plus chers
Modification
Afin de ne pas faire des milliers d'appelle inutile par seconde, on fait le GET /habilitations/:habilitationId a l'api-depot seulement si l'habilitationId est un ObjectId valide