Skip to content

fix: optimize profile_by_app_group_name to query only active AppGroups #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ce314007 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: optimize profile_by_app_group_name to query only active AppGroups #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c8fd5b
fix: optimize profile_by_app_group_name to query only active AppGroups
Oct 18, 2024
c7b3759
feat : update conditions if the helm infra not found
Oct 18, 2024
67a2e58
feat: update condition
Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/controllers/api/v2/infrastructures_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,11 @@ def profile_by_cluster_name

def profile_by_app_group_name
@app_group = AppGroup.find_by(
name: params[:app_group_name]
name: params[:app_group_name],
status: "ACTIVE"
)

if @app_group.blank? || !@app_group.ACTIVE?
if @app_group.blank?
render(json: {
success: false,
errors: ['App Group not found'],
Expand Down
3 changes: 2 additions & 1 deletion app/controllers/api/v3/infrastructures_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,10 @@ def authorize_by_username
def profile_by_app_group_name
@app_group = AppGroup.find_by(
name: params[:app_group_name],
status: "ACTIVE"
)

if @app_group.blank? || !@app_group.ACTIVE?
if @app_group.blank?
render(json: {
success: false,
errors: ['App Group not found'],
Expand Down