Skip to content

Update for 1.12#277

Open
ethsmith wants to merge 2 commits intoBaccayarro:masterfrom
ethsmith:master
Open

Update for 1.12#277
ethsmith wants to merge 2 commits intoBaccayarro:masterfrom
ethsmith:master

Conversation

@ethsmith
Copy link
Copy Markdown

@ethsmith ethsmith commented Mar 2, 2018

I updated this to use 1.12 packages. Maybe at some point, if I had the time I could make an Abstraction util so that Movecraft could support all versions.

@ethsmith
Copy link
Copy Markdown
Author

ethsmith commented Mar 2, 2018

I just noticed there was already a PR for 1.12 but this one is a bit more thorough. I plan to use this updated version myself so I thought I would send a PR for others.

@ethsmith
Copy link
Copy Markdown
Author

ethsmith commented Mar 2, 2018

It has been tested and works great.

@brandonyoungdev
Copy link
Copy Markdown

Do you have a build .jar that you could share?

@ethsmith
Copy link
Copy Markdown
Author

ethsmith commented Apr 8, 2018

@Brandutchmen If you open it in your favorite ide or use maven on the command line you can build it immediately but I will get a download to the jar asap as possible for you.

@brandonyoungdev
Copy link
Copy Markdown

@ThisIzEthan My maven gave me a lot of dependency errors. =(

@ethsmith
Copy link
Copy Markdown
Author

ethsmith commented Apr 9, 2018

https://github.com/ThisIzEthan/Movecraft-3/releases/tag/1.12
@Brandutchmen I built it for you. You can post an issue if you have problems but should work fine.

@brandonyoungdev
Copy link
Copy Markdown

Thank You.
Do you by a chance know what is causing my dependency errors? It is tending to revolve around the cannons and vault plugins.

@ethsmith
Copy link
Copy Markdown
Author

@Brandutchmen Might have to have your ide reindex the maven repositories in the pom.xml

@TylerS1066
Copy link
Copy Markdown

@ThisIzEthan @Brandutchmen I recommend moving over to https://github.com/APDevTeam/Movecraft for dicsussions, PRs, and the rest. This repo has been abandoned for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants