Allow extra chests in exchange for unused dispensers.#243
Open
gosella wants to merge 1 commit intoBaccayarro:masterfrom
Open
Allow extra chests in exchange for unused dispensers.#243gosella wants to merge 1 commit intoBaccayarro:masterfrom
gosella wants to merge 1 commit intoBaccayarro:masterfrom
Conversation
This patch allows to automatically extend the upper limit for chests and trapped chests, adding one extra chest for every three dispensers not used (but allowed) on the craft.
No other block limit is changed (including the craft size) and it won't affect any of the current crafts (but allows to manually remove dispensers and replace them with chests).
Additionally, the detection process now gives more information when a fly block limit is not met (not only percentages but also block counts and craft size). It also reports all the violations found (not only the first one). Examples:
Not enough flyblock: redstone block -> 9 < 10 (1,00% of 1000)
or
Too much flyblock: chest -> 31 > 29 (3,00% of 999) + 1 extra (in exchange for 3 dispensers)
Not enough flyblock: redstone block -> 8 < 9 (1,00% of 999)
This feature is controlled by the config entry `ExchangeDispensersForChests` which is `false` by default (for backward compatibility).
|
damn that's good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows to automatically extend the upper limit for chests and trapped chests, adding one extra chest for every three dispensers not used (but allowed) on the craft.
No other block limit is changed (including the craft size) and it won't affect any of the current crafts (but allows to manually remove dispensers and replace them with chests).
Additionally, the detection process now gives more information when a fly block limit is not met (not only percentages but also block counts and craft size). It also reports all the violations found (not only the first one). Examples:
or
This feature is controlled by the config entry
ExchangeDispensersForChestswhich isfalseby default (for backward compatibility).