Reimplement legacy `Sound` class with new audio engine #17457

docEdub · 2025-11-14T21:59:03Z

No description provided.

bjsplat · 2025-11-14T22:04:35Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-14T22:19:29Z

Snapshot stored with reference name:
refs/pull/17457/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17457/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17457/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17457/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge#BCU1XR#0

bjsplat · 2025-11-14T22:25:39Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-14T22:29:38Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-14T22:33:27Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-14T22:43:13Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-14T22:46:54Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T20:46:57Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T20:55:16Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T20:56:13Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T20:57:54Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T21:24:34Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T21:32:08Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T21:33:41Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T21:35:09Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T21:38:55Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-17T22:40:07Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T22:43:19Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T22:48:19Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T22:50:00Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T22:55:33Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…tructed

bjsplat · 2025-11-18T14:31:27Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

See playground #KBA3JY#4.

bjsplat · 2025-11-18T14:36:44Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-18T15:02:31Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-18T15:03:42Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-18T15:10:32Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-18T15:12:27Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-18T15:21:39Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…utton press

…on Firefox If the arg `startTime` is even slightly in the future, Firefox throws an error. This change avoids that error and achieves the same desired result of canceling any scheduled values.

bjsplat · 2025-11-18T16:34:32Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-18T16:41:44Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-18T16:47:21Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-18T16:52:06Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-18T16:53:06Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-18T17:51:02Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-18T18:00:29Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-18T18:02:38Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-18T18:03:56Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-18T18:06:48Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…ial node

New audio engine `maxDistance` defaults to `10000`, but old `Sound` class should default to `100`. This change fixes it so it defaults to `100` correctly in all cases.

New audio engine `distanceModel` defaults to `inverse`, but old `Sound` class should default to `linear`. This change fixes it so it defaults to `linear` correctly in all cases.

bjsplat · 2025-11-18T21:39:41Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-19T17:03:11Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-19T17:05:11Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-19T17:12:34Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-19T17:15:09Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-19T17:21:21Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

Reimplement legacy Sound class with new audio engine

7375134

Fix case where Sound is constructed but audio engine is not available

eb0bcc4

docEdub force-pushed the 251114-reimplement-old-sound-class branch from 33d1d2f to eb0bcc4 Compare November 17, 2025 21:03

docEdub added the audio label Nov 17, 2025

docEdub added 2 commits November 17, 2025 17:13

Fix sound not setting playback loop option correctly

870db99

Show unmute button when sound is set to autoplay and engine is locked

8fb0eb7

Fix autoplay property not being set correctly after Sound is cons…

f2464f6

…tructed

Fix audio engine unlock when useCustomUnlockedButton is true

ca391fe

See playground #KBA3JY#4.

docEdub added 3 commits November 18, 2025 10:56

Wait for Firefox to unlock audio context before playing after legit b…

811662b

…utton press

Change cancelScheduledValues arg to 0 to ensure they're canceled …

8132365

…on Firefox If the arg `startTime` is even slightly in the future, Firefox throws an error. This change avoids that error and achieves the same desired result of canceling any scheduled values.

Fix autoplay issue

1635d77

docEdub added 4 commits November 18, 2025 14:56

Return valid GainNode from Sound.getSoundGain()

8b386d1

Remove stereoPan option so stereo panner node doesn't override spat…

d208ba9

…ial node

Fix spatial maxDistance default for old Sound class

0c69771

New audio engine `maxDistance` defaults to `10000`, but old `Sound` class should default to `100`. This change fixes it so it defaults to `100` correctly in all cases.

Fix spatial distanceModel default for old Sound class

c7ab966

New audio engine `distanceModel` defaults to `inverse`, but old `Sound` class should default to `linear`. This change fixes it so it defaults to `linear` correctly in all cases.

deltakosh approved these changes Nov 21, 2025

View reviewed changes

Reimplement legacy Sound class with new audio engine #17457

Are you sure you want to change the base?

Reimplement legacy Sound class with new audio engine #17457

Conversation

docEdub commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

Reimplement legacy `Sound` class with new audio engine #17457

Reimplement legacy `Sound` class with new audio engine #17457