Add option to use boundingBox (instead of boundingSphere) when calculating arcRotateCam lowerRadius. Add orthographic framing #17329
+77
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the PR proposed here: #17292
Adds new optional param 'mode' to the framingBehavior zoomOnBoundingInfo. If specified, calls into the camera's new _calculateLowerRadiusFromModelBoundingInfo function which respects the passed in mode and adds orthographic framing
If no mode is sent, default to old behavior (using cameras _calculateLowerRadiusFromModelBoundingSphere fn, and not adding orthographic framing)
This maintains backwards compatibility of old behavior while still offering option to use new behavior