Skip to content

Conversation

@georginahalpern
Copy link
Contributor

This is a refactor of the PR proposed here: #17292

  • Adds new optional param 'mode' to the framingBehavior zoomOnBoundingInfo. If specified, calls into the camera's new _calculateLowerRadiusFromModelBoundingInfo function which respects the passed in mode and adds orthographic framing

  • If no mode is sent, default to old behavior (using cameras _calculateLowerRadiusFromModelBoundingSphere fn, and not adding orthographic framing)

This maintains backwards compatibility of old behavior while still offering option to use new behavior

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@PietroFurlan
Copy link

I work a lot with BabylonJS and I love getting my hands dirty with the code.
Unfortunately, I can’t share my main projects, but if you’re interested, I have some other integrations like this one that I can share.

For example, I’ve made a “light” version of the OBJExporter that can shrink mesh size by up to 60%, by skipping details like normals, materials, etc.

Let me know if you’re interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants