Skip to content

Conversation

HiGregSmith
Copy link
Contributor

@HiGregSmith HiGregSmith commented Oct 21, 2025

Added target and currentTarget properties to ColorPicker onValueChangedObservable.

Test with this playground: https://playground.babylonjs.com/?snapshot=refs/pull/17322/merge#ZMLBW6#8

See this forum post for more details: https://forum.babylonjs.com/t/obtain-gui-component-within-onvaluechangedobservable-on-slider-and-colorpicker/61045/8

Added target and currentTarget properties to ColorPicker onValueChangedObservable.
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@HiGregSmith HiGregSmith marked this pull request as draft October 21, 2025 10:48
@HiGregSmith HiGregSmith changed the title Update colorpicker.ts Update colorpicker.ts onValueChanged enabled second parameter, event/state Oct 21, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@HiGregSmith HiGregSmith marked this pull request as ready for review October 21, 2025 12:03
Copy link
Contributor

@georginahalpern georginahalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description to link to the forum post / test playground. Thanks!

@sebavan sebavan merged commit e51ee0a into BabylonJS:master Oct 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants