-
Notifications
You must be signed in to change notification settings - Fork 3.6k
OpenPBR Fuzz layer #17308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OpenPBR Fuzz layer #17308
Conversation
4933f23
to
b312824
Compare
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17308/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17308/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17308/merge#BCU1XR#0 |
Devhost visualization test reporter: |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Devhost visualization test reporter: |
Visualization tests for WebGPU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiiBond could we add the generation of the texture within our texture tools ? we have all our brdf sources there. https://github.com/BabylonJS/BabylonjsTextureTools/tree/master/src/brdf
@sebavan I have a python script that parses the ltc_table_sheen_volume.cpp file from that Github repo. Should I just post the .py file and instructions how to use it? I don't think we should copy and paste their .cpp file, should we? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed some of it. I didn't review the math in the shader as I don't know it.
.../components/actionTabs/tabs/propertyGrids/materials/openpbrMaterialPropertyGridComponent.tsx
Show resolved
Hide resolved
yup not sure either let s discuss on your PR there. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
This implements the OpenPBR fuzz slab for prefiltered and realtime filtered IBL as well as analytic lights.
OpenPBR uses this model and I've generated and included the LUT for it:
https://github.com/tizian/ltc-sheen?tab=readme-ov-file