Skip to content

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Oct 16, 2025

This implements the OpenPBR fuzz slab for prefiltered and realtime filtered IBL as well as analytic lights.

OpenPBR uses this model and I've generated and included the LUT for it:
https://github.com/tizian/ltc-sheen?tab=readme-ov-file

@MiiBond MiiBond force-pushed the mbond/openpbr-fuzz branch from 4933f23 to b312824 Compare October 16, 2025 21:53
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 16, 2025

@sebavan sebavan requested a review from bghgary October 17, 2025 21:23
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2025

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiiBond could we add the generation of the texture within our texture tools ? we have all our brdf sources there. https://github.com/BabylonJS/BabylonjsTextureTools/tree/master/src/brdf

@MiiBond
Copy link
Contributor Author

MiiBond commented Oct 20, 2025

@sebavan I have a python script that parses the ltc_table_sheen_volume.cpp file from that Github repo. Should I just post the .py file and instructions how to use it? I don't think we should copy and paste their .cpp file, should we?

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed some of it. I didn't review the math in the shader as I don't know it.

@sebavan
Copy link
Member

sebavan commented Oct 20, 2025

@sebavan I have a python script that parses the ltc_table_sheen_volume.cpp file from that Github repo. Should I just post the .py file and instructions how to use it? I don't think we should copy and paste their .cpp file, should we?

yup not sure either let s discuss on your PR there.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17308/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17308/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17308/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17308/merge/testResults/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants