Skip to content

Clamp NdotV to 0.0 for diffuse roughness #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented May 7, 2025

For prefiltered IBL, using the "dominant direction" approximation for diffuse roughness, slightly negative NdotV values weren't being handled, resulting in artifacts.

Screenshot 2025-05-07 at 1 54 25 PM Screenshot 2025-05-07 at 1 54 04 PM

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants