Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native: Canvas Path2D #16221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Pheo
Copy link

@Pheo Pheo commented Feb 26, 2025

Adds Path2D https://developer.mozilla.org/en-US/docs/Web/API/Path2D
This calls to BabylonNative as implemented in BabylonJS/BabylonNative#1469

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2025

@CedricGuillemet
Copy link
Contributor

Must be merged after BabylonJS/BabylonNative#1469

CedricGuillemet pushed a commit to BabylonJS/BabylonNative that referenced this pull request Feb 28, 2025
- https://developer.mozilla.org/en-US/docs/Web/API/Path2D

Adds nanosvg.h for SVG path parsing.
Known missing functionality:
1. `addPath` doesn't accept DOMMatrix transform
2. `roundRect` doesn't accept CSS-style radii array
3. `ellipse` doesn't handle clockwise

Called from BabylonJS/Babylon.js#16221
@Pheo Pheo force-pushed the CanvasPath2DImplementation branch from e56b98a to 17b0a30 Compare February 28, 2025 13:29
@Pheo Pheo marked this pull request as ready for review February 28, 2025 13:30
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2025

@RaananW
Copy link
Member

RaananW commented Feb 28, 2025

@CedricGuillemet , the referenced PR seems to be merged, can we merge this?

@CedricGuillemet
Copy link
Contributor

@CedricGuillemet , the referenced PR seems to be merged, can we merge this?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants