Add OpenPBR's base_weight material parameter #16085
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
virtualzavie
changed the title
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16085/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16085/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16085/merge#BCU1XR#0 |
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
| surfaceAlbedo *= vBaseWeight; | ||
| #if BASEWEIGHT | ||
| surfaceAlbedo *= baseWeightTexture.r; | ||
| #endif |
There was a problem hiding this comment.
Pending discussion with OpenPBR group to confirm the specified behaviour.
packages/dev/core/src/Shaders/ShadersInclude/pbrUboDeclaration.fx
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Shaders/ShadersInclude/pbrVertexDeclaration.fx
Outdated
Show resolved
Hide resolved
|
Visualization tests for WebGPU (Experimental) |
|
Visualization tests for WebGPU (Experimental) |
This PR implements the
base_weightparameter from the OpenPBR specification.This parameter simply scales linearly the
base_color(named albedo in Babylon.js).Test scene:
https://playground.babylonjs.com/?snapshot=refs/pull/16085/merge#DT1XPP#4