-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KHR_draco_mesh_compression support to glTF Exporter #16064
base: master
Are you sure you want to change the base?
Add KHR_draco_mesh_compression support to glTF Exporter #16064
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
… track encode promises in extension
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16064/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16064/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16064/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
packages/dev/serializers/src/glTF/2.0/Extensions/EXT_mesh_gpu_instancing.ts
Outdated
Show resolved
Hide resolved
packages/dev/serializers/src/glTF/2.0/Extensions/EXT_mesh_gpu_instancing.ts
Outdated
Show resolved
Hide resolved
for (let index = 0; index < array.length; index++) { | ||
newArray[index] = array[index]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be replaced with .set
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, since we're trying to convert from possibly Float32Array to Uint8/16Array. Using .set() on a lower-byte TypedArray, with a higher-byte TypedArray as the param, hasn't seemed to work for me.
Visualization tests for WebGPU (Experimental) |
This PR adds the ability to export to glTF using Draco encoding. Some notes: