Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IES file support #15949

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Introduce IES file support #15949

merged 8 commits into from
Dec 4, 2024

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Dec 4, 2024

This is the first step.
After merging this PR, I will work on the shaders for webgl and webgpu
Then I will add the support for EXT_FILES_IES for gltf :)

Associated with #15000

@deltakosh deltakosh enabled auto-merge (squash) December 4, 2024 19:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh changed the title Fix #15000 Introduce IES file support Dec 4, 2024
sebavan
sebavan previously approved these changes Dec 4, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a loader like tga ?

@sebavan sebavan self-requested a review December 4, 2024 20:01
@sebavan sebavan dismissed their stale review December 4, 2024 20:02

prevent merge for now

@deltakosh
Copy link
Contributor Author

The way I plan it is to have a iesTexture property on the spotlight so I see this as an helper to provide the texture. But I can switch to a loader but that will be more complex I think

@deltakosh deltakosh disabled auto-merge December 4, 2024 20:06
@deltakosh deltakosh marked this pull request as draft December 4, 2024 20:06
@deltakosh
Copy link
Contributor Author

Switching to draft as @sebavan had a really good point!

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

@deltakosh deltakosh marked this pull request as ready for review December 4, 2024 20:52
@deltakosh deltakosh enabled auto-merge (squash) December 4, 2024 20:52
@deltakosh deltakosh merged commit 7bd5833 into master Dec 4, 2024
11 of 13 checks passed
@deltakosh deltakosh deleted the ies branch December 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants