-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IES file support #15949
Introduce IES file support #15949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15949/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15949/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15949/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a loader like tga ?
The way I plan it is to have a iesTexture property on the spotlight so I see this as an helper to provide the texture. But I can switch to a loader but that will be more complex I think |
Switching to draft as @sebavan had a really good point! |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
packages/dev/core/src/Materials/Textures/Loaders/iesTextureLoader.ts
Outdated
Show resolved
Hide resolved
…der.ts Co-authored-by: Popov72 <[email protected]>
This is the first step.
After merging this PR, I will work on the shaders for webgl and webgpu
Then I will add the support for EXT_FILES_IES for gltf :)
Associated with #15000