Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculated material life cycle environmental impact factors and support for setting A4 #357

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Oct 7, 2024

Depends on:

BHoM/BHoM#1641

Issues addressed by this PR

Targets initial parts of #306

  • Update evaluation methods to be able to handle new CalculatedMaterialLifeCycleEnvironmentalImpactFactors as well as EPDS
  • Add method for Dynamically creating a new EnviromentalMetric based on provided type, using the same mechanisms as result creation
  • Add method for explicitly assigning A4 value for climate change.

Test files

Will provide at later stage.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Oct 7, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Oct 7, 2024
@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Oct 7, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Oct 7, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

1 similar comment
Copy link

bhombot-ci bot commented Oct 7, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh IsakNaslundBh changed the title Life cycle assessment toolkit #306 add calculated material life cycle environmental impact factors Add calculated material life cycle environmental impact factors and support for setting A4 Oct 15, 2024
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review October 22, 2024 06:29
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Oct 28, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

There are 18 requests in the queue ahead of you.

…latedMaterialLifeCycleEnvironmentalImpactFactors
@IsakNaslundBh IsakNaslundBh marked this pull request as draft December 9, 2024 14:40
@IsakNaslundBh IsakNaslundBh added the status:WIP PR in progress and still in draft, not ready for formal review label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant