Skip to content

Feature/#28 webcam preview#32

Merged
parkminjo merged 12 commits intodevfrom
Feature/#28-webcam-preview
Apr 4, 2025
Merged

Feature/#28 webcam preview#32
parkminjo merged 12 commits intodevfrom
Feature/#28-webcam-preview

Conversation

@parkminjo
Copy link
Copy Markdown
Collaborator

💡 관련이슈

🍀 작업 요약

  1. 사용자 웹캠을 연결할 수 있는 로직을 작성했습니다.
  2. 사용자의 마이크를 연결하면 녹음이 되는 로직을 작성했습니다.

💬 리뷰 요구 사항

웹캠과 마이크가 잘 연결되는지, 녹음하기 버튼을 클릭했을 때 녹음도 잘 되는지 확인해주시면 감사하겠습니다.

💛 미리보기

스크린샷 2025-04-04 오전 9 55 37

@parkminjo parkminjo self-assigned this Apr 4, 2025
@parkminjo parkminjo added ✨ Feature 기능 개발 D-1 긴급하게 처리해야 하지만 D-0보다는 상대적으로 여유 있는 작업입니다. 중요한 작업으로 빠른 진행이 요구됩니다. ☕️민조 labels Apr 4, 2025
Copy link
Copy Markdown
Collaborator

@choichangyeon choichangyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 확인했습니다!
코드리뷰 확인해주세요!
감사합니다!

Comment thread src/features/interview/camera-view.tsx Outdated
Copy link
Copy Markdown
Collaborator

@ImJaeOne ImJaeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커멘트 확인해주십쇼!

Comment thread package.json
Comment thread src/features/interview/hooks/useAudioRecorder.ts Outdated
Copy link
Copy Markdown
Collaborator

@choichangyeon choichangyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크럼에서 진행된 내용에 대해 확인 부탁드리겠습니다!

Comment thread src/features/interview/hooks/useAudioRecorder.ts
Copy link
Copy Markdown
Collaborator

@ImJaeOne ImJaeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Collaborator

@choichangyeon choichangyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Copy Markdown
Collaborator

@hye410 hye410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 분들이 벌써 리뷰를 잘 달아주셨네요!
테스트 해봤는데 잘 동작합니다 넘 신기하네용ㅎㅎㅎ

@parkminjo parkminjo merged commit f01be3e into dev Apr 4, 2025
1 check passed
@parkminjo parkminjo deleted the Feature/#28-webcam-preview branch April 4, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-1 긴급하게 처리해야 하지만 D-0보다는 상대적으로 여유 있는 작업입니다. 중요한 작업으로 빠른 진행이 요구됩니다. ☕️민조 ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants