Skip to content

Featuer/#29 sign in validation#30

Merged
ImJaeOne merged 12 commits intodevfrom
Featuer/#29-sign-in-validation
Apr 4, 2025
Merged

Featuer/#29 sign in validation#30
ImJaeOne merged 12 commits intodevfrom
Featuer/#29-sign-in-validation

Conversation

@ImJaeOne
Copy link
Copy Markdown
Collaborator

@ImJaeOne ImJaeOne commented Apr 3, 2025

💡 관련이슈

🍀 작업 요약

로그인 유효성 검사
상수 구조 분해 할당으로 사용

💬 리뷰 요구 사항

없습니다~!

💛 미리보기

Apr-03-2025 22-27-22

@ImJaeOne ImJaeOne added ✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 🕶️ 재원 재원 D-1 긴급하게 처리해야 하지만 D-0보다는 상대적으로 여유 있는 작업입니다. 중요한 작업으로 빠른 진행이 요구됩니다. labels Apr 3, 2025
@ImJaeOne ImJaeOne self-assigned this Apr 3, 2025
Copy link
Copy Markdown
Collaborator

@choichangyeon choichangyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 확인해주세요!

Comment thread src/features/auth/sing-in/sign-in-auth-form.tsx
Copy link
Copy Markdown
Collaborator

@hye410 hye410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재원님 고생하셨습니다!
나중에 input 박스 포커스일 때 border 생기는 것만 수정 부탁드려욥
className에 focus:outline-0만 추가해 주시면 됩니다~

  • as-is
image
  • to-be
image

Copy link
Copy Markdown
Collaborator

@choichangyeon choichangyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Copy Markdown
Collaborator

@parkminjo parkminjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 고생 많으셨습니다

@ImJaeOne ImJaeOne merged commit f33659d into dev Apr 4, 2025
1 check passed
@ImJaeOne ImJaeOne deleted the Featuer/#29-sign-in-validation branch April 4, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-1 긴급하게 처리해야 하지만 D-0보다는 상대적으로 여유 있는 작업입니다. 중요한 작업으로 빠른 진행이 요구됩니다. ✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 🕶️ 재원 재원

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants