Add website field to tenant management utils#147
Conversation
Add website parameter to update_tenant_metadata(), display it in _print_tenant(), and add test coverage. Bump governance client to v0.0.17 which includes the website field.
There was a problem hiding this comment.
Pull request overview
This PR extends the tenant management utilities to support a new website metadata field end-to-end (update + display), aligned with an updated governance client that includes website in the tenant models.
Changes:
- Add
websiteparameter toupdate_tenant_metadata()and pass it into theTenantMetadataUpdaterequest body. - Display
websitein_print_tenant()output (affectingshow_my_tenants()rendering). - Update tests/fixtures to cover website updates and printing; bump
minio-manager-service-clienttov0.0.17.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| notebook_utils/berdl_notebook_utils/minio_governance/tenant_management.py | Adds website support to metadata updates and prints website in tenant detail output. |
| notebook_utils/tests/minio_governance/test_tenant_management.py | Adds a focused test for updating website, updates detail fixture, and asserts website appears in printed output. |
| notebook_utils/pyproject.toml | Bumps governance client source revision to v0.0.17. |
| notebook_utils/uv.lock | Updates the lockfile to match the v0.0.17 governance client revision/commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notebook_utils/berdl_notebook_utils/minio_governance/tenant_management.py
Show resolved
Hide resolved
…house/spark_notebook into feature/tenant-website-field
Summary
websiteparameter toupdate_tenant_metadata()and pass it through to the governance clientwebsitein_print_tenant()outputtest_updates_websitetest and update_make_detailfixtureCompanion to BERDataLakehouse/minio_manager_service#52
Test plan
update_tenant_metadata("tenant", website="https://example.com")works end-to-endshow_my_tenants()displays website field