-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade node from 18-bullseye to 25.6.1-bullseye #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| FROM node:18-bullseye | ||||||
| FROM node:25.6.1-bullseye | ||||||
|
||||||
| FROM node:25.6.1-bullseye | |
| FROM node:22-bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade jumps from Node.js 18 to 25, which spans 7 major versions (18→19→20→21→22→23→24→25). Each major version can introduce breaking changes to the Node.js runtime and APIs.
The Dockerfile clones an external project (OpenMaxIO/openmaxio-object-browser v1.7.6) that was likely developed and tested against Node.js 18. There's no guarantee this project is compatible with Node.js 25, and the build process involves compiling a web application with yarn and building Go code that may have Node.js dependencies.
Before merging, you should:
Node.js 20 LTS would provide security fixes while being a more conservative upgrade path with better stability guarantees.