Skip to content

Conversation

@openapi-sdkautomation
Copy link

Create to sync Azure/azure-rest-api-specs#14832

Installation Instructions

In order to use the generated nuget package in your app, you will have to use it from a private feed.
To create a private feed, see the following link:
https://docs.microsoft.com/en-us/nuget/hosting-packages/local-feeds
This will allow you to create a new local feed and add the location of the new feed as one of the sources.

Direct Download

The generated package can be directly downloaded from here:

@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14832/Microsoft.Azure.Management.SecurityInsights branch 3 times, most recently from 6950172 to de320af Compare June 16, 2021 14:20
maririos and others added 26 commits July 2, 2021 10:54
* updates

* Update sdk/textanalytics/Azure.AI.TextAnalytics/README.md

Co-authored-by: Krista Pratico <[email protected]>

Co-authored-by: Krista Pratico <[email protected]>
…zure#21988)

* Mark EventListener using tests as non-parallelizable

* Adjust test that throws exceptions from indexing action handlers
Reduce number of documents used in the test so that EventSource does not log a very large number of events.

* Do not create proxies from proxies

* Fix more tests to avoid event exceptions

* Use GetOriginal() helper method when creating proxies
* Generate AKS SDK for 2021-05-01 API

* Remove deprecated test

* Update package info

* Update test record

Co-authored-by: Kaiqi Zhang <[email protected]>
# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.

### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.

## Additional management plane SDK specific contribution checklist: 
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
 
- [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata).
- [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
	- Do not modify any code in generated folders.
	- Do not selectively include/remove generated files in the PR.
	- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
	Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
	
	**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:

	    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

### Old outstanding PR cleanup
 Please note:
	If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
…failures generating new SDKs (Azure#21765)

* Update DataCollectionRulesTests.cs

commenting out the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK.

* Update DataCollectionRulesTests.cs

Commenting this the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK.
* Limit number of events stored in TestEventListener

* Throw exception when events are dropped
Increase default max event count to 1000.

* Dispose the event listener in AzureIdentityEventSourceTests

* Add comments on TestEventListener ctor

* Dispose TestEventListener in a timely manner

* Use method local TestEventListener in Search
Reason: The ACS SDKs (including Identity) are being handed over to the respective service teams.
* Add interop sample

* File header

* PR FB
Increment package version after release of Azure.Core.Amqp
* Service Bus extension API updates

* MaxEventBatchSize
* Cancel lock renewal when closing receiver

* Revert and fix tests

* Fix whitespace

* Lower timeouts

* lock duration

* fix

* fix

* Fix sync over async

* revert

* Remove cast

* Fix example

* Fix test
* Fix *ModelFactory namespaces

* Build fix

* Revert TextAnalyticsModelFactory changes

* Undo some incorrect changes

* Revert namespace changes in Azure.Communication

* Revert "Revert namespace changes in Azure.Communication"

This reverts commit c4feed4.

* Fix namespaces in Azure.Communication

* Revert change

* Fix autorest.md for timeseriesinsights

* Fix Azure.Communication.Identity build
* added WorkspaceFeatures.cs

* updated version from .23 to .24

* ran autorest code

* added the .txt file needed for PR

* re ran the generage.ps1 script - so it now includes operationalinsights_resource-manager.txt

* moved DataExport.cs to Customization folder to avoide deletion by autorest.
this file contains a manual change from auto gen code

* made DataExport.cs under Customization folder a partial class that only contains the missing inheritance, left all other autogen code as is
The focus of these changes is to prepare the Event Hubs core package for
the July milestone release.
Increment package version after release of Azure.Data.Tables
* update mixed reality sample

* update readme issue

* Delete AssetConversionProcessSample.cs

* update readme

* remove invalid changes
Mohit-Chakraborty and others added 24 commits July 29, 2021 17:01
Update GitHub id to one that is MS approved
* add tag to index
* ensure that generate-api-docs updates the ga token as well
…22968)

* combine extension classes

* updates to more comments

* make autorest attributes internal

* update api

* update based on pr feedback
* combine extension classes

* updates to more comments

* make autorest attributes internal

* update api

* update based on pr feedback

* update internal types to work with autorest

* updates after merge
* Generated code.

Updated generation

Generated comments.

Spec changes

Missing comma.

Spec fixe

Spec updates

Spec updates

Fixed VirtualMachineConfiguration

Spec changes

Spec changes

Spec changes

Updated ContainerRegistry

Updated ProtocolLayer

Fix object comparison

Fixed generator System.Object issue, NodeVMExtension.VmExtension casing

* Fixed AllocationTimedOut casing to match service response.

* Linting and formatting

Readme formatting

* Changelog and version

Updated version

* ImageReference fix

* Updated dependency version

* PR Comments
* update names based on feedback

* update api

* rename params to match class names

* update api
* add sub library to include azure.resourcemanager

* update old form track2 projects to opt out of new core package
* Generated control plane

Added generated descriptions.

* Updated version

PR SDK updates

Updated version

sdkinfo

* Changelog lint fixes.

Added markdown config

Ignore MD013

Change log update

Expanded change log.

* Tests

AutoStorage AuthenticationMode memoery test

Switched to static resource name.

Scenario tests

Added ListOutboundNetworkDependenciesEndpoints test

OsDisk scenario test

Tests AllowedAuthenticationModes

ComputeNodeIdentityReference test

* Cleanup

* Session Records

Updated test recordings

Updated recordings

Updated recordings

Updated session records

* Fixed breaking change

Fixed breacking change

* Updated SDKInfo

Updated generation.

* Added BatchAccountIdentity constructor and test for equality against old type.

* Fixed version.

Fixed version.
* Update Changelog for Aug 2021 release

* Add a statement about the bug fix in the release

* Remove info about token value from changelog
The focus of these changes is to move the resources used in the Canary
cloud to a new region, as the existing region appears to be out of
capacity for IoT Hub instances.
* Comment out artifact entries for track1 packages

* Align comment character across lines
* Add overrides for cspell sanitation
* Update Migration guide

* Mention migration guide in Readme

* Fixing typos

* Update MigrationGuide.md

* Addressing Mark's comments

* Addressing comments

* Update code snippets

* Update MigrationGuide.md

* Replace construct() in Network

* Replace Construct() in Compute

* Update code snippets and fix typos

* Structured Resource Identifier

* Addressing Structured Resource Identifier comments

* Update code snippets

* Resource Identifier Try methods

* Replacing 'Var'

* Replacing Var in 'New' code snippets

* Update Sample3 - Create a VNet

* Replace 'var' in track1 code

* Spelling fixes

* Apply suggestions from code review

Co-authored-by: Mark Cowlishaw <[email protected]>

* Addressing comments from review

Co-authored-by: Mark Cowlishaw <[email protected]>
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14832/Microsoft.Azure.Management.SecurityInsights branch from fa34a65 to ad420a8 Compare August 2, 2021 15:04
tlecomte and others added 3 commits August 2, 2021 09:32
…TimeOffset (Azure#23050)

`AbsoluteExpiryTime` from `Microsoft.Azure.Amqp` is a `DateTime`. On the other hand, `AmqpMessage.Properties.AbsoluteExpiryTime` is a `DateTimeOffset`. Some `DateTime` cannot be converted to `DateTimeOffset`, causing `ArgumentOutOfRangeException` ("The UTC time represented when the offset is applied must be between year 0 and 10,000."). This has been observed on a message that was sent and received using `Azure.Messaging.ServiceBus` between 2 processes running in the EST timezone.

Here the `AmqpMessageConverter` is adjusted to work when the `DateTime` is out of range.

A unit test is added. This unit test fails without the change to the `AmqpMessageConverter`, and when the timezone of the local machine is set to a timezone that lags behind UTC.
Merge 9ce66b4ea61453793488ac96bd2eea7a1b3bc6a4 into f528ab6315c8d4dd4c36f363851d491798a78146
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14832/Microsoft.Azure.Management.SecurityInsights branch from ad420a8 to dcb6289 Compare August 2, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.