-
Notifications
You must be signed in to change notification settings - Fork 8
Replace hardcoded NuGet package versions with NuGet Package Manager guidance in Walkthrough 2 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…uidance Co-authored-by: blgorman <[email protected]>
| <PackageReference Include="Polly" Version="7.2.4" /> | ||
| </ItemGroup> | ||
| ``` | ||
| >**Note:** To ensure you have the latest and correct packages for your Azure Functions project (.NET 6 LTS), it is recommended to use the NuGet Package Manager to install the required dependencies rather than hardcoding specific versions. This approach prevents errors that may occur over time as versions and dependencies evolve, and will help prevent issues during Task 4 when setting up a pipeline in GitHub Actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can we update this to .NET 8 instead of .NET 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all .NET 6 references to .NET 8 in the ImageProcessing walkthrough, including the NuGet package guidance, SDK download link, and Azure Function App deployment instructions. Commit 81432cc
blgorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Can you take a look and see if we can update these instructions to reflect .NET 8 and isolated workers in the function app (might need to change the packages to map to the isolated versions?)
| - Install the latest stable version | ||
|
|
||
| Feel free to perform any reasonable upgrades to minor versions should any exist in your NuGet Package Manager. | ||
| >**Important:** This approach is NOT for the isolated version of Azure Functions. Isolated functions are not yet tested for this workshop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this and utilize .NET 8 with isolated workers for the function app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the note about isolated functions not being tested and updated the entire walkthrough to use .NET 8 isolated worker functions with proper packages and configuration. Commit 23bb75a
Co-authored-by: blgorman <[email protected]>
… proper packages and code examples Co-authored-by: blgorman <[email protected]>
Updated the instructions to use .NET 8 isolated worker Azure Functions with proper package references and code examples. Replaced all WebJobs packages with their isolated worker equivalents and added Program.cs setup guidance. Commit 23bb75a |
Updated Task 1 (part 3) in
02-ImageProcessingAndStorageEvents.mdto replace outdated hardcoded package versions with comprehensive NuGet Package Manager instructions.Problem
The walkthrough documentation contained a hardcoded XML snippet with specific package versions that could become outdated over time:
This approach led to potential issues:
Solution
Replaced the hardcoded XML with step-by-step NuGet Package Manager instructions for all 10 required packages:
Each package now includes clear instructions:
Benefits
Fixes #13.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.