-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Custom auth/alban/ai leverage copilot #7716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
albanx
wants to merge
110
commits into
dev
Choose a base branch
from
custom-auth/alban/ai-leverage-copilot
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add msal-custom-auth to pipeline
Update Error handling and log pii info
…sample-skeleton [CustomAuth] Create React JS Sample skeleton will address Jian comment in the next merge
This PR is for: 1. Updating all the log level to use verbose for better debug purposes. 2. Update index.ts to expose sdk components
Angular Sample skeleton
This PR is to 1. Add doc to all public components 2. Update index.ts for missing classes
… correlationid agnostic fetch client
[Fix] Fix development on local and remove not needed checks, improved…
1. Merge the latest changes from dev branch to feature branch. 2. Remove the unused sample app --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Thomas Norling <[email protected]> Co-authored-by: Sameera Gajjarapu <[email protected]> Co-authored-by: Robbie-Microsoft <[email protected]> Co-authored-by: MSAL.js Release Automation <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: shylasummers <[email protected]>
This PR is to add support for web fallback for (sign-up, sign-in, reset password) flows. 1. Existing code already check during those flows if challenge types is `redirect `only. In this case, user could check this condition from state, and handle it. 2. By default, user could reuse the built-in `popUpLogin` from MSAL JS to continue to flow with a pop up interactively. 3. Make sure challenge type at least contains `redirect`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with Copilot