Bgdnext64/85 add more terraform samples#252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands MPF’s documentation and sample artifacts for Terraform (and ARM) by adding ready-to-use “initial permissions” JSON files and updating docs to reflect the current --jsonOutput behavior and Terraform module targeting usage.
Changes:
- Add sample JSON permission seed files for Terraform remote backend access and ARM initial permissions.
- Update docs with new examples for
--jsonOutput,--initialPermissions, and Terraform--targetModule. - Bump the Go version declared in
go.mod.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
samples/terraform/backend-permissions.json |
Adds a reusable initial-permissions JSON sample for Terraform remote backend scenarios. |
samples/templates/arm-initial-permissions.json |
Adds a reusable initial-permissions JSON sample for ARM deployments. |
go.mod |
Updates the declared Go version. |
docs/installation-and-quickstart.md |
Adds ARM/Terraform JSON output examples and initial-permissions guidance. |
docs/display-options.MD |
Updates JSON output examples to match current formatter output and adds Terraform JSON/detailed sections. |
docs/commandline-flags-and-env-variables.md |
Adds module-targeting example and expands initial-permissions / remote backend guidance. |
maniSbindra
requested changes
Apr 23, 2026
maniSbindra
left a comment
maniSbindra
left a comment
Contributor
There was a problem hiding this comment.
One minor change suggested
- Add ARM JSON output example to installation-and-quickstart.md - Add ARM --initialPermissions examples (comma-separated and @file.json) to installation-and-quickstart.md - Add ARM --initialPermissions examples to commandline-flags-and-env-variables.md - Fix --outputFormat json (non-existent flag) to --jsonOutput in display-options.MD - Fix JSON output sample to match actual output format (flat map of scope to permissions) - Add arm-initial-permissions.json sample file
- Add language specifiers to fenced code blocks (MD040) - Add blank line before heading (MD022)
…itial permissions - Add Terraform JSON output, --targetModule, and --initialPermissions examples to installation-and-quickstart.md (bash + PowerShell) - Add Terraform JSON output and detailed output sections to display-options.MD with --varFilePath for ACI sample - Add --targetModule usage example to commandline-flags-and-env-variables.md - Enhance Terraform remote backend --initialPermissions example with full env var setup, PowerShell variant, and reference to #172 - Create samples/terraform/backend-permissions.json sample file Closes #85
- Rename ARM JSON heading to 'ARM with Known Permissions (JSON File)' - Reference provided backend-permissions.json sample by relative path - Quote @file paths in PowerShell --initialPermissions examples - Update Bicep JSON output description to flat scope->permissions map
bgdnext64
force-pushed
the
bgdnext64/85-add-more-terraform-samples
branch
from
4ff51b0 to
811f5e8
Compare
maniSbindra
approved these changes
Jun 9, 2026
maniSbindra
left a comment
maniSbindra
left a comment
Contributor
There was a problem hiding this comment.
accepted as readability formatting in docs; not blocking.
Contributor
|
@bgdnext64 there are some conflicts, could those be resolved. Thanks, Mani |
…-terraform-samples # Conflicts: # docs/display-options.MD
maniSbindra
approved these changes
Jun 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.