feat(controller): add persistent sandbox workspaces - #494
Open
掌柜的 (nikawang) wants to merge 3 commits into
Open
Conversation
掌柜的 (nikawang)
requested review from
Johnson Shi (johnsonshi),
Lachlan Evenson (lachie83) and
Pal Lakatos-Toth (pallakatos)
as code owners
August 8, 2026 05:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sandbox, including dynamic claims, explicit existing-claim recovery, Retain/Delete lifecycle safety, andStorageReadystatusAGENTS.md,SOUL.md,HEARTBEAT.md,TOOLS.md, andUSER.md, with atomic writes, digest provenance, symlink defenses, and init-container credential isolationkars add, Helm CRD/RBAC, generated CRD validation, lifecycle docs, and security guidance while preservingemptyDiras the backward-compatible defaultRelated Issues
None.
Type of Change
Checklist
make test)Testing
cargo test --locked -p kars-controller— 886 controller tests passed; phase taxonomy guard passedcargo clippy --locked -p kars-controller --bin kars-controller --no-deps -- -D warnings -A clippy::uninlined_format_argscargo fmt --all -- --checknpm test -- --exclude src/commands/dev.test.ts— 928 stable CLI tests passednpm test -- --run src/commands/add.test.ts— 30/30 add-command tests passednpm run typecheck && npm run lint && npm run build— typecheck/build passed; lint reported 0 errors (29 pre-existing warnings outside this change)kubectl apply --dry-run=server -f deploy/helm/kars/templates/crd.yaml— CRD OpenAPI/CEL accepted by the API serverbash -nfor both OpenClaw scripts, plus executable bootstrap behavior tests coveringIfMissing,Always, SHA-256 state manifest, file symlink rejection, and destination/state directory symlink rejectionmake testis intentionally left unchecked: the local repository-wide wrapper invokes unrelated Python/secret-scanner gates that currently fail on pre-existing fixtures and paths outside this diff. The component-native Rust and TypeScript suites above are the executable validation for this change.