fix(cli): accept canonical langgraph --runtime flag (keep lang-graph alias)#483
Open
pallakatos wants to merge 1 commit into
Open
fix(cli): accept canonical langgraph --runtime flag (keep lang-graph alias)#483pallakatos wants to merge 1 commit into
langgraph --runtime flag (keep lang-graph alias)#483pallakatos wants to merge 1 commit into
Conversation
…ph` alias) The CLI flag parser only accepted the hyphenated `lang-graph`, so `kars add x --runtime langgraph` failed with "Unknown --runtime value" — even though the `--runtime` help text, docs, controller (`plan_langgraph`), runtime images (`kars-runtime-langgraph`) and Helm values all use the unhyphenated `langgraph`. Make `langgraph` canonical in FLAG_TO_KIND and the operator picker; keep `lang-graph` working via a dedicated FLAG_ALIASES map that is not surfaced in pickers or the valid-values error text. Adds tests for both spellings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
kars add <name> --runtime langgraphfails today:The CLI flag parser (
cli/src/runtime.ts) only accepted the hyphenatedlang-graph, but the unhyphenatedlanggraphis the canonical spelling used everywhere else:--runtimehelp text (add.ts) — so the tool contradicted itselfdocs/cli-reference.md,docs/runtimes.md,README.mdplan_langgraph,langgraph_default_image()kars-runtime-langgraph, dirsruntimes/langgraph/runtimes.langgraph.image--runtime langgraphlang-graphwas an accidental island in just the CLI flag parser + operator picker. This also makes the--runtime langgraphexample in the getting-started guide / launch materials work out of the box.Fix
langgraphis now the canonical flag inFLAG_TO_KINDand the operator TUI picker.lang-graphkeeps working via a dedicatedFLAG_ALIASESmap consulted byflagToKind()— but it is not surfaced in pickers (wiredRuntimeFlags), the reverseKIND_TO_FLAGmap, or the "Valid values" error text. No breakage for existing scripts.Tests
langgraphand legacylang-graph(case-insensitive) both resolve toLangGraph.wiredRuntimeFlags()expected-set test tolanggraph.Verification (local)
tsc --noEmitcleannpm test— 933 passed / 2 skipped (28 runtime tests incl. 4 new)npm run lint— 0 errorsNo release cut with this PR — folding into the next batched release.