-
Notifications
You must be signed in to change notification settings - Fork 70
Fleet bump #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fleet bump #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f7361a to
460c15a
Compare
nwnt
reviewed
Dec 16, 2024
template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
Show resolved
Hide resolved
nwnt
reviewed
Dec 16, 2024
template/workflows/kustomize/.github/workflows/azure-kubernetes-service-kustomize.yml
Show resolved
Hide resolved
nwnt
reviewed
Dec 16, 2024
template/workflows/manifests/.github/workflows/azure-kubernetes-service.yml
Show resolved
Hide resolved
nwnt
reviewed
Dec 16, 2024
template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
Outdated
Show resolved
Hide resolved
nwnt
reviewed
Dec 16, 2024
template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
Outdated
Show resolved
Hide resolved
461d5f3 to
efa2935
Compare
jim-minter
suggested changes
Dec 18, 2024
pkg/fixtures/workflows/github/helm/.github/workflows/azure-kubernetes-service-helm.yml
Outdated
Show resolved
Hide resolved
pkg/fixtures/workflows/github/helm/.github/workflows/azure-kubernetes-service-helm.yml
Show resolved
Hide resolved
pkg/fixtures/workflows/github/helm/.github/workflows/azure-kubernetes-service-helm.yml
Outdated
Show resolved
Hide resolved
template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
Outdated
Show resolved
Hide resolved
343a8fd to
ebf87ca
Compare
davidgamero
requested changes
Dec 30, 2024
...fixtures/workflows/github/kustomize/.github/workflows/azure-kubernetes-service-kustomize.yml
Outdated
Show resolved
Hide resolved
...fixtures/workflows/github/kustomize/.github/workflows/azure-kubernetes-service-kustomize.yml
Outdated
Show resolved
Hide resolved
template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
Show resolved
Hide resolved
b506f3e to
dae9d89
Compare
davidgamero
approved these changes
Jan 2, 2025
Collaborator
davidgamero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
32c2444 to
730a22a
Compare
Revert file to master cleaned up more cleaning Update generate-workflow.go revert changes removed unnecessary changes removed kubeconfig env updated tidied yaml file Update setup-gh.go made changes in wf helpers test devhub integration removed fleet input added resource type changes, deployment changes based on devhub draft manifest template for fleet version bump removed changes besides template draft changes for helm and kustomize changed resource type to cluster resource type changed resource type name nit changes nits Fleet changes for draft fixed unit tests added fixture changes Update azure-kubernetes-service-helm.yml Fix typo in CLUSTER_RESOURCE_TYPE value testing changes changes to helm template
bfoley13
approved these changes
Jan 2, 2025
davidgamero
approved these changes
Jan 2, 2025
Collaborator
davidgamero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
auto-merge was automatically disabled
January 3, 2025 16:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.
Version bump for fleet integration with Draft
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).
Checklist: