Skip to content

Conversation

@audrastump
Copy link
Member

@audrastump audrastump commented Dec 13, 2024

Description

Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.
Version bump for fleet integration with Draft
Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@audrastump audrastump force-pushed the fleetBump branch 2 times, most recently from 461d5f3 to efa2935 Compare December 17, 2024 00:56
@audrastump audrastump marked this pull request as ready for review December 19, 2024 19:09
@audrastump audrastump force-pushed the fleetBump branch 2 times, most recently from 343a8fd to ebf87ca Compare December 19, 2024 20:42
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@audrastump audrastump force-pushed the fleetBump branch 3 times, most recently from 32c2444 to 730a22a Compare January 2, 2025 19:11
audrastump and others added 5 commits January 2, 2025 11:38
Revert file to master

cleaned up

more cleaning

Update generate-workflow.go

revert changes

removed unnecessary changes

removed kubeconfig env

updated

tidied yaml file

Update setup-gh.go

made changes in wf helpers

test devhub integration

removed fleet input

added resource type changes, deployment changes based on devhub

draft manifest template for fleet version bump

removed changes besides template

draft changes for helm and kustomize

changed resource type to cluster resource type

changed resource type name

nit changes

nits

Fleet changes for draft

fixed unit tests

added fixture changes

Update azure-kubernetes-service-helm.yml

Fix typo in CLUSTER_RESOURCE_TYPE value

testing changes

changes to helm template
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero enabled auto-merge (squash) January 2, 2025 21:21
@davidgamero davidgamero closed this Jan 3, 2025
auto-merge was automatically disabled January 3, 2025 16:37

Pull request was closed

@davidgamero davidgamero reopened this Jan 3, 2025
@davidgamero davidgamero enabled auto-merge (squash) January 3, 2025 16:38
@davidgamero davidgamero merged commit 025d8f9 into Azure:main Jan 3, 2025
287 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants