-
Couldn't load subscription status.
- Fork 284
[MCP] describe_entities tool fixes and refactoring #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the describe-entities tool to describe_entities and enhances its functionality to provide comprehensive entity metadata including descriptions, fields for stored procedures, and permissions.
- Renamed tool from
describe-entitiestodescribe_entitiesacross configuration and implementation - Enhanced entity response to include descriptions, fields for stored procedures, and permissions
- Added proper documentation and error handling to the tool implementation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Config/ObjectModel/DmlToolsConfig.cs | Updated comments to reflect the new tool name |
| src/Config/Converters/DmlToolsConfigConverter.cs | Updated JSON property name and validation logic |
| src/Cli/ConfigGenerator.cs | Updated logging message to use new tool name |
| src/Cli/Commands/ConfigureOptions.cs | Updated CLI option name for the tool |
| src/Azure.DataApiBuilder.Mcp/BuiltInTools/DescribeEntitiesTool.cs | Major refactoring with enhanced functionality and documentation |
| schemas/dab.draft.schema.json | Updated JSON schema property name and description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Azure.DataApiBuilder.Mcp/BuiltInTools/DescribeEntitiesTool.cs
Outdated
Show resolved
Hide resolved
src/Azure.DataApiBuilder.Mcp/BuiltInTools/DescribeEntitiesTool.cs
Outdated
Show resolved
Hide resolved
This reverts commit eeac569.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will test this with Claude to see if there are any other errors.
… Usr/sogh/describe-entities
…://github.com/Azure/data-api-builder into dev/anushakolan/mcp/add-field-description-new
…scription-new' into Usr/sogh/describe-entities
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The changes have been made
Why make this change?
Closes on
describe_entities#2827Added fixes and refactored the describe_entities tool to support entity metadata discovery for AI agents and LLM clients before performing CRUD operations.
What is this change?
How was this tested?
Functional testing using Insomnia client by running DAB in localhost and local SQL DB database
Expected (In-progress) format of entity description in response-
Sample Request(s)