Add authentication validation to the JSON schema #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot sure if this is intended but it makes sense to me.
…sed. The error message is a bit janky, though
sander1095
requested review from
Aniruddh25,
aaronburtle,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Apr 13, 2025
Aniruddh25
reviewed
Apr 13, 2025
Aniruddh25
approved these changes
Apr 13, 2025
|
@Aniruddh25 I've processed your comments. I took a look at the failures of the CI pipeline of the last commits. They seem to be unrelated to my changes: Let's hope that a re-run will make them go green! |
|
@RubenCerna2079 Could you perform a re-run on this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2643
The JSON schema does not contain a list of auth providers, nor does it validate the use of the
jwtproperty. This results in a suboptimal developer experience. By adding this list and validation, developers have an easier time learning about all the options and can be more productive.What is this change?
This change modifies the JSON schema with a list of providers and validation of the providers and the
jwtproperty.StackOverflow helped me with the finer details of the validation.
I also added tests to validate my changes.
How was this tested?
Sample Request(s)