-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Json Schema validations for optional fields #2611
Merged
sezal98
merged 7 commits into
main
from
dev/abhishekkuma/fix-schema-validation-no-optional-field
Mar 24, 2025
Merged
Fix Json Schema validations for optional fields #2611
sezal98
merged 7 commits into
main
from
dev/abhishekkuma/fix-schema-validation-no-optional-field
Mar 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/fix-schema-validation-no-optional-field
/azp run |
sezal98
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new UT and reviewed PR
/azp run |
RubenCerna2079
approved these changes
Mar 15, 2025
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
@microsoft-github-policy-service agree company="Microsoft" |
1 similar comment
@microsoft-github-policy-service agree company="Microsoft" |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
dab.draft.schema.json
optional field types withnull
to allow for optional fields to be evaluated correctly during schema validation.How was this tested?
Sample Request(s)
config:

Before Fix:

After Fix:
