Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Json Schema validations for optional fields #2611

Merged

Conversation

abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Mar 4, 2025

Why make this change?

What is this change?

  • updated the dab.draft.schema.json optional field types with null to allow for optional fields to be evaluated correctly during schema validation.

How was this tested?

  • Manual Tests
  • Unit Tests

Sample Request(s)

config:
image

Before Fix:
image

After Fix:
image

@abhishekkumams
Copy link
Contributor Author

/azp run

Copy link
Contributor

@sezal98 sezal98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new UT and reviewed PR

@sezal98
Copy link
Contributor

sezal98 commented Mar 13, 2025

/azp run

@RubenCerna2079
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@sezal98 sezal98 enabled auto-merge (squash) March 17, 2025 16:02
@sezal98
Copy link
Contributor

sezal98 commented Mar 18, 2025

@microsoft-github-policy-service agree company="Microsoft"

1 similar comment
@abhishekkumams
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@sezal98
Copy link
Contributor

sezal98 commented Mar 19, 2025

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@Aniruddh25
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@sezal98 sezal98 merged commit aee9690 into main Mar 24, 2025
11 checks passed
@sezal98 sezal98 deleted the dev/abhishekkuma/fix-schema-validation-no-optional-field branch March 24, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🥕[Bug]: Validate requires optional sections
4 participants