-
Notifications
You must be signed in to change notification settings - Fork 296
Implement depth-limit to GraphQL Queries/Mutation operations For Non-Hosted Scenario #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement depth-limit to GraphQL Queries/Mutation operations For Non-Hosted Scenario #2267
Conversation
|
/azp run |
|
/azp run |
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some test structure changes requested and more comments needed.
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some additional suggestions/nits based on latest changes.
… dev/abhishekkuma/add-nesting-limit-gql-queries
|
/azp run |
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits. Looks good! thank you for making these features additions and testing.
|
/azp run |
|
/azp run |
|
/azp run |
aaronburtle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
/azp run |
Why make this change?
What is this change?
.AddMaxExecutionDepthRuleprovided by Hot Chocolate.dab.draft.schema.jsonfile to allow both integer and null value for depth-limit.How was this tested?
Sample Request(s)
#nested depth: 8
{ books(filter: {id: {eq: 1}}){ items{ id title publishers { id name books (filter: {authors: {id: {isNull: false}}}){ items { authors{ items{ id name } } } } } } } }nested depth: 3
{ book_by_pk(id: 2){ id publishers { id name } } }Mutation (nested depth: 7)