Repository navigation
fix(controller): tolerate delayed webhook certificate startup - #115
Draft
jmclong (jmclong) wants to merge 1 commit into
Draft
jmclong (jmclong) wants to merge 1 commit into
jmclong (jmclong) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
jmclong (jmclong)
force-pushed
the
dev/jlong/fix-webhook-startup-probes
branch
from
October 16, 2026 13:54
b05cb9b to
4f29754
Compare
Keep process liveness independent of certificate readiness and allow a bounded startup window in the Helm chart. Preserve certificate and webhook gating for readiness. Add simple unit coverage for disabled webhooks, pending certificates, webhook startup, and readiness. Do not add E2E coverage or readiness diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0c077ebb-9cd5-4c85-a49d-0178a7f67a57
jmclong (jmclong)
force-pushed
the
dev/jlong/fix-webhook-startup-probes
branch
from
October 16, 2026 13:59
4f29754 to
5cd5656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep process liveness independent of certificate readiness and allow a bounded startup window in the Helm chart.
Add a controller E2E regression that withholds certificate files for 90 seconds and verifies healthy liveness, blocked readiness, and zero restarts. The regression passes on Minikube with the fix and fails against the unchanged manager.
Summary
Validation
Related issue