-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AzCLI instead of client secret creds #2906
base: main
Are you sure you want to change the base?
Conversation
…into wendi/azcli-auth pull.
…rage-azcopy into wendi/azcli-auth pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks/suggestions, nothing ship-sinking. Looks good!
@@ -50,10 +50,8 @@ type NewE2EConfig struct { | |||
} `env:",required"` | |||
|
|||
StaticStgAcctInfo struct { | |||
StaticOAuth struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could be done as an either/or setup
weigh this with a grain of salt, most of the team will probably do inherited auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a similar note, could it be set up to allow AzCLI or AzPwsh inheritance? Some people on the team use one or the other, not usually both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the option of Pwsh as a separate PR just to keep things simple now. @adreed-msft could you create an item for that under AzCopy as a library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. If adding Pwsh as an option is easy enough, feel free to add it in this PR as an alternative. Otherwise, please work with Adele to make sure its tracked for a future add.
Description
Changes:
NEW_E2E_STATIC_CLIENT_SECRET
.Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!