Added sdk/storage/azure_storage_queue (#2730) #2732
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2708 Added support for the 2018-03-28 Queue API. The following functions have been created on the new QueueClient, roughly following the pattern in the .Net SDK: queue_client: new create create_if_not_exists clear delete delete_if_exists delete_message exists get_metadata get_properties enqueue_message dequeue_message dequeue_messages peek_message peek_messages set_metadata update_message get_access_policy set_access_policy queue_service_client: new create_queue delete_queue get_properties set_properties list_queues_segment (paginated) Examples of how to use each method has been provided in the ~/sdk/storage/examples/queue_client.rs file. Recorded tests has also been pushed to the repo Azure/azure-sdk-assets and the assets.json updated. The client is generated using tsp-client using remote Azure/azure-rest-api-specs repo.
lsiddiquee
requested review from
hallipr,
weshaggard,
heaths,
RickWinter,
LarryOsterman,
vincenttran-msft,
jalauzon-msft and
ronniegeraghty
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements initial support for the 2018-03-28 Queue API in the Azure Storage Queue SDK for Rust. Key changes include the introduction of new client functions for managing queues, a comprehensive test suite covering the new operations, and several example programs and documentation updates.
Reviewed Changes
Copilot reviewed 18 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_queue/tsp-location.yaml | Adds configuration metadata for the queue API |
| sdk/storage/azure_storage_queue/tests/queue_service_client.rs | Introduces recorded tests for queue service |
| sdk/storage/azure_storage_queue/src/lib.rs | Sets up module exports for clients and models |
| sdk/storage/azure_storage_queue/src/clients/queue_service_client.rs | Implements QueueServiceClient API functions |
| sdk/storage/azure_storage_queue/examples/* | Provides usage examples and helper functions |
| sdk/storage/azure_storage_queue/Cargo.toml | Configures the crate with required dependencies and features |
| sdk/storage/azure_storage_queue/CHANGELOG.md | Documents the initial supported release |
| sdk/storage/assets.json | Updates asset references |
| sdk/storage/.dict.txt | Updates custom dictionary with new terms |
| Cargo.toml | Adds the queue SDK to the workspace members |
Comments suppressed due to low confidence (1)
sdk/storage/azure_storage_queue/src/clients/queue_service_client.rs:90
- The documentation for the 'queue_name' parameter in the delete_queue function incorrectly states that it is 'to create' the queue. Please update the description to indicate that it is the name of the queue to delete.
/// * `queue_name` - The name of the queue to create
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
lsiddiquee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2708
Added support for the 2018-03-28 Queue API. The following functions have been created on the new QueueClient, roughly following the pattern in the .Net SDK:
queue_client:
new
create
create_if_not_exists
clear
delete
delete_if_exists
delete_message
exists
get_metadata
get_properties
enqueue_message
dequeue_message
dequeue_messages
peek_message
peek_messages
set_metadata
update_message
get_access_policy
set_access_policy
queue_service_client:
new
create_queue
delete_queue
get_properties
set_properties
list_queues_segment (paginated)
Examples of how to use each method has been provided in the
sdk/storage/examples/queue_client.rsfile.Recorded tests has also been pushed to the repo
Azure/azure-sdk-assetsand theassets.jsonupdated.The client is generated using tsp-client using remote
Azure/azure-rest-api-specsrepo.