Skip to content

Update fixedint dependency #43475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update fixedint dependency #43475

wants to merge 2 commits into from

Conversation

@jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Oct 16, 2025 •
edited
Loading

Description

Fixedint was added and pinned one day before the latest version came out. Updating it to allow for the latest version. Should be removed in the future.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Oct 16, 2025
@jeremydvoss jeremydvoss marked this pull request as ready for review October 17, 2025 17:36
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 17:36
Copilot
Copilot AI reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relaxes the fixedint dependency from an exact pin to a version range to allow future compatible updates and records the change in the unreleased changelog section.

  • Updated setup.py to change fixedint from ==0.1.6 to >=0.1.6,<1.0.0
  • Added a changelog note documenting the dependency adjustment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sdk/monitor/azure-monitor-opentelemetry-exporter/setup.py Adjusts fixedint dependency specification to a wider semver range.
sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md Adds entry noting the relaxed fixedint dependency constraint.

@jeremydvoss jeremydvoss changed the title Unpin fixedint Remove fixedint Oct 17, 2025
@jeremydvoss jeremydvoss mentioned this pull request Oct 17, 2025
Closed
6 tasks
lzchen
lzchen reviewed Oct 17, 2025
View reviewed changes
...itor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py Outdated
_SAMPLING_HASH = 5381
_INTEGER_MAX: int = Int32.maxval
_INTEGER_MIN: int = Int32.minval
_INTEGER_MAX: int = 2147483647
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something like


_INT32_MAX = 2**31 - 1   # 2147483647
_INT32_MIN = -2**31      # -2147483648

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

rads-1996
rads-1996 reviewed Oct 17, 2025
View reviewed changes
sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md Outdated
### Bugs Fixed

### Other Changes
- Remove fixedint dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we never require fixedint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only used for a single constant. It's not a good reason to increase or vulnerability surface.

rads-1996
rads-1996 reviewed Oct 17, 2025
View reviewed changes
...itor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py Outdated
_SAMPLING_HASH = 5381
_INTEGER_MAX: int = Int32.maxval
_INTEGER_MIN: int = Int32.minval
_INTEGER_MAX: int = 2147483647
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.py also uses from fixedint import Int32

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, let me see if that's needed

@jeremydvoss
Copy link
Member Author

Converting to draft until we investigate more

@jeremydvoss jeremydvoss marked this pull request as draft October 17, 2025 18:28
@jeremydvoss
Copy link
Member Author

Needs tests for _get_DJB2_sample_score.

@jeremydvoss jeremydvoss changed the title Remove fixedint Update fixedint dependency Oct 22, 2025
@jeremydvoss jeremydvoss marked this pull request as ready for review October 22, 2025 17:40
rads-1996
rads-1996 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@rads-1996 rads-1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lzchen lzchen lzchen approved these changes

@rads-1996 rads-1996 rads-1996 approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@Karlie-777 Karlie-777 Awaiting requested review from Karlie-777 Karlie-777 is a code owner

@MSNev MSNev Awaiting requested review from MSNev MSNev is a code owner

@JacksonWeber JacksonWeber Awaiting requested review from JacksonWeber JacksonWeber is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremydvoss @lzchen @rads-1996