Initial get_token to fill credential cache #43468
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk-for-python into tvaron3/get_token
…sdk-for-python into tvaron3/get_token
…sdk-for-python into tvaron3/get_token
…into tvaron3/get_token
…into tvaron3/get_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, azure credentials don't protect against concurrent calls at setup to populate cache. This could result in extra unnecessary calls aad calls at bootup before the cache in the credential is filled. Customers should use a singleton credential and share it across their cosmos clients. There are several layers of caching for aad calls. This change is targeting populating the cache in the token credential to be filled with only one request.
Solution
Cosmos client will now keep a static map of the credential instance and their corresponding locks, and each client will perform one get_token on the credential to fill up the cache. If getting the token fails, the exception is swallowed and logged as a warning. This approach was taken to not affect or reimplement the fallback logic for fabric.