Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fix debug info #40187

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Search fix debug info #40187

merged 4 commits into from
Mar 25, 2025

Conversation

xiangyan99
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@xiangyan99 xiangyan99 marked this pull request as ready for review March 21, 2025 21:08
@xiangyan99 xiangyan99 requested review from Copilot and pvaneck March 21, 2025 21:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the deserialization issue for document_debug_info in search results and updates the code generation metadata to use AutoRest version 6.30.0.

  • Fixed the deserialization bug by changing document_debug_info from a list to a single object.
  • Updated the AutoRest generator version across multiple generated files.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/search/azure-search-documents/CHANGELOG.md Added changelog entry for the document_debug_info deserialization bug fix
sdk/search/azure-search-documents/azure/search/documents/_generated/_search_index_client.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/models/_search_index_client_enums.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/_configuration.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/models/_models_py3.py Changed document_debug_info type and its initialization to reflect a single debug info object
sdk/search/azure-search-documents/azure/search/documents/_generated/aio/_configuration.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/aio/_search_index_client.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/models/init.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/aio/init.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/operations/init.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/operations/_documents_operations.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/aio/operations/_documents_operations.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/init.py Updated AutoRest generator version
sdk/search/azure-search-documents/azure/search/documents/_generated/aio/operations/init.py Updated AutoRest generator version
Comments suppressed due to low confidence (1)

sdk/search/azure-search-documents/azure/search/documents/_generated/models/_models_py3.py:1842

  • The updated initialization for document_debug_info now supports a single debug info object instead of a list. Verify that any client consuming this model is adjusted to handle a single object.
        self.document_debug_info: Optional["_models.DocumentDebugInfo"] = None

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will trust that you've verified the service response works with what is being deserialized here. Would be good to get some live/recorded tests at some point to verify that responses are correctly parsed when additional data is sent back.

@xiangyan99 xiangyan99 merged commit 9b6cd2a into main Mar 25, 2025
24 checks passed
@xiangyan99 xiangyan99 deleted the search_fix_debug_info branch March 25, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants