Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target mar preview test #40172

Merged
merged 2 commits into from
Mar 24, 2025
+9 −7
Merged

target mar preview test #40172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346cda1
march preview test
kristapratico Mar 21, 2025
0dad465
fix for vector_store tests
kristapratico Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/openai/azure-openai/tests/conftest.py
View file
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@

# for pytest.parametrize
GA = "2024-10-21"
PREVIEW = "2025-02-01-preview"
PREVIEW = "2025-03-01-preview"
LATEST = PREVIEW

AZURE = "azure"
8 changes: 5 additions & 3 deletions sdk/openai/azure-openai/tests/test_vector_stores.py
View file
Original file line number Diff line number Diff line change
@@ -52,12 +52,14 @@ def test_vector_stores_crud(self, client: openai.AzureOpenAI | openai.OpenAI, ap
name="Support FAQ and more",
metadata={"Q": "A"}
)

assert vector_store.name == "Support FAQ and more"
assert vector_store.metadata == {"Q": "A"}

retrieved_vector = client.vector_stores.retrieve(
vector_store_id=vector_store.id
)
assert retrieved_vector.id == vector_store.id
assert retrieved_vector.name == "Support FAQ and more"
assert retrieved_vector.metadata == {"Q": "A"}

vector_store_file = client.vector_stores.files.create(
vector_store_id=vector_store.id,
@@ -88,7 +90,7 @@ def test_vector_stores_crud(self, client: openai.AzureOpenAI | openai.OpenAI, ap
os.remove(path)
deleted_vector_store_file = client.vector_stores.files.delete(
vector_store_id=vector_store.id,
file_id=file.id
file_id=vector_store_file.id
)
assert deleted_vector_store_file.deleted is True
deleted_vector_store = client.vector_stores.delete(
6 changes: 3 additions & 3 deletions sdk/openai/azure-openai/tests/test_vector_stores_async.py
View file
Original file line number Diff line number Diff line change
@@ -52,12 +52,12 @@ async def test_assistants_vector_stores_crud(self, client_async: openai.AsyncAzu
name="Support FAQ and more",
metadata={"Q": "A"}
)
assert vector_store.name == "Support FAQ and more"
assert vector_store.metadata == {"Q": "A"}
retrieved_vector = await client_async.vector_stores.retrieve(
vector_store_id=vector_store.id
)
assert retrieved_vector.id == vector_store.id
assert retrieved_vector.name == "Support FAQ and more"
assert retrieved_vector.metadata == {"Q": "A"}

vector_store_file = await client_async.vector_stores.files.create(
vector_store_id=vector_store.id,
@@ -88,7 +88,7 @@ async def test_assistants_vector_stores_crud(self, client_async: openai.AsyncAzu
os.remove(path)
deleted_vector_store_file = await client_async.vector_stores.files.delete(
vector_store_id=vector_store.id,
file_id=file.id
file_id=vector_store_file.id
)
assert deleted_vector_store_file.deleted is True
deleted_vector_store = await client_async.vector_stores.delete(