Splitting up test_crud and test_crud_async #40149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR splits the existing test_crud file into separate files for database, container, and document-level tests.
- Separation of synchronous and asynchronous CRUD tests for improved maintainability
- Consolidation of database-level CRUD test logic in two newly created files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_crud_database.py | Introduces synchronous database-level CRUD tests extracted from the original test_crud file |
| sdk/cosmos/azure-cosmos/tests/test_crud_database_async.py | Introduces asynchronous database-level CRUD tests extracted from the original test_crud_async file |
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting up test_crud and test_crud_async file into test_crud_database, test_crud_container, and test_crud will be used for the document level tests. This splits up the massive test_crud file and makes the tests more maintainable.