Skip shared/arm files during scaffolding, handle it centrally #53381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live1206
requested review from
ArcturusZhang,
JoshLove-msft,
benbp,
hallipr,
jorgerangel-msft,
m-nash and
weshaggard
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the management generator's scaffolding process to handle shared ARM files centrally rather than during project scaffolding. The change removes redundant file inclusion logic from the generator and relies on the build system's existing infrastructure to include shared files.
Key Changes:
- Simplified the
NewManagementProjectScaffoldingclass by removing ARM shared file handling logic - Updated build configuration to include shared files for generator library generation tests
- Removed explicit shared file references from test project file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Azure.Generator.MgmtTypeSpec.Tests.csproj |
Removed explicit reference to SharedExtensions.cs that is now handled centrally |
NewManagementProjectScaffolding.cs |
Simplified BuildCompileIncludes() to return empty list, removing ARM shared file scaffolding logic |
Directory.Build.Common.targets |
Extended condition to include generator test projects in centralized shared file inclusion |
...-mgmt/generator/Azure.Generator.Management/src/Primitives/NewManagementProjectScaffolding.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
added
CodeGen
….Management/src/Primitives/NewManagementProjectScaffolding.cs Co-authored-by: Copilot <[email protected]>
|
The CI failure is due to #53340 (comment) |
live1206
changed the title
ArcturusZhang
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.