Azure.ResourceManager.Avs 1.0.0-preview.1

[cataggar]

This is the start of Azure.ResourceManager.Avs, generated off the 2021-12-01 API Azure/azure-rest-api-specs#16426 like Microsoft.Azure.Management.Avs 3.0.0 #25276.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please open PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.
• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

• Include updated management metadata.
• Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

• If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

• If the check fails at the Verify Code Generation step, please ensure:

  • Do not modify any code in generated folders.
  • Do not selectively include/remove generated files in the PR.
  • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
    Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

  Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
  

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

[cataggar]

Currently getting duplicate GetDhcp & GetPortMirroring members in WorkloadNetworkSegment.cs, but not sure why.

Build FAILED.

C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Generated\WorkloadNetworkSegment.cs(515,59): error CS0111: Type 'WorkloadNetworkSegment' already defines a member called 'GetDhcpAsync' with the same parameter types [C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Azure.ResourceManager.Avs.csproj]
C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Generated\WorkloadNetworkSegment.cs(477,54): error CS0111: Type 'WorkloadNetworkSegment' already defines a member called 'GetDhcp' with the same parameter types [C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Azure.ResourceManager.Avs.csproj]
C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Generated\WorkloadNetworkSegment.cs(667,68): error CS0111: Type 'WorkloadNetworkSegment' already defines a member called 'GetPortMirroringAsync' with the same parameter types [C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Azure.ResourceManager.Avs.csproj]
C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Generated\WorkloadNetworkSegment.cs(629,63): error CS0111: Type 'WorkloadNetworkSegment' already defines a member called 'GetPortMirroring' with the same parameter types [C:\Users\cataggar\io\azure-sdk-for-net\sdk\avs\Azure.ResourceManager.Avs\src\Azure.ResourceManager.Avs.csproj]
    0 Warning(s)
    4 Error(s)

[cataggar]

Here are a couple of conflicting signatures:

public virtual Response<WorkloadNetworkDhcp> GetDhcp(CancellationToken cancellationToken = default){}

public virtual Pageable<WorkloadNetworkDhcp> GetDhcp(CancellationToken cancellationToken = default){}

[cataggar]

This is the description for WorkloadNetwoks_ListDhcp. The method should be named ListWorkloadNetworkDhcpAsync, not GetWorkloadNetworkDhcpAsync.

azure-sdk-for-net/sdk/avs/Azure.ResourceManager.Avs/src/Generated/PrivateCloud.cs

Lines 844 to 847 in deb889a

	/// <summary> List dhcp in a private cloud workload network. </summary>
	/// <param name="cancellationToken"> The cancellation token to use. </param>
	/// <returns> An async collection of <see cref="WorkloadNetworkDhcp" /> that may take multiple service requests to iterate over. </returns>
	public virtual AsyncPageable<WorkloadNetworkDhcp> GetWorkloadNetworkDhcpAsync(CancellationToken cancellationToken = default)

[check-enforcer]

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

[ghost]

Hi @cataggar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

[cataggar]

@msftbot, be nice

[ghost]

Hi @cataggar. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.