Skip to content

Conversation

@arpja
Copy link
Contributor

@arpja arpja commented Jan 6, 2021

Adding new changes for 2020-12-01 api version.

Adding new changes for 2020-12-01 api version.
@YalinLi0312
Copy link

@arpja Please fix the failing checks.

arpja added 3 commits January 7, 2021 11:35
Fixing compilation errors
- fixing the api backupstorageconfig api by calling 2017 api version.
- fixed test case json to use new api version
Adding new api version in test jsons
@arpja
Copy link
Contributor Author

arpja commented Jan 7, 2021

@arpja Please fix the failing checks.

Hi @YalinLi0312,
Please review changes now, I have fixed the compile and test failures.

@arpja arpja closed this Jan 7, 2021
@arpja arpja reopened this Jan 7, 2021
@arpja
Copy link
Contributor Author

arpja commented Jan 8, 2021

Hi @YalinLi0312,
I closed the PR by mistake, reopened it immediately.
Please review now.

@arpja
Copy link
Contributor Author

arpja commented Jan 9, 2021

Hi @YalinLi0312 @nisha-bhatia,
Could you please review this PR?
I have fixed the compile and test failures.

@arpja
Copy link
Contributor Author

arpja commented Jan 11, 2021

Hi @YalinLi0312, @markcowl @allenjzhang @bquantump @m-nash @nisha-bhatia,
Could anyone of you please approve this PR if it looks ok?
Our powershell release is awaiting this change.
Would appreciate quicker review for this PR.

@YalinLi0312
Copy link

@arpja Could you provide the swagger review PR link for the updates in this PR?

@arpja
Copy link
Contributor Author

arpja commented Jan 12, 2021

Hi @YalinLi0312
Here is the swagger review PR:
Azure/azure-rest-api-specs#12171

@arpja
Copy link
Contributor Author

arpja commented Jan 13, 2021

Hello @YalinLi0312
any thoughts? let me know if you have any comments

@YalinLi0312
Copy link

@arpja Could you:

  • Check in the metadata TXT file generated when you run generate.ps1(details)
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

Updating version and release notes
@arpja
Copy link
Contributor Author

arpja commented Jan 18, 2021

Hi @YalinLi0312
Updated the PR

@arpja
Copy link
Contributor Author

arpja commented Jan 19, 2021

Hi @YalinLi0312
I'm seeing this strange behavior where merge validation fails for generated files with a compile error that an interface is not implemented by a class (Logs: https://dev.azure.com/azure-sdk/public/_build/results?buildId=692080&view=logs&j=ad07b744-5a1a-5d54-7693-fcb02e666633&t=88540a4e-0b51-541f-e623-7b2636eab300 )
When I resolve the error by manually adding the required method in class the merge validation fails again stating that the code is not generated (Logs: https://dev.azure.com/azure-sdk/public/_build/results?buildId=691912&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=3374e909-b3a0-5fde-4fba-1f1bb546637f)

Can you please let me know if I'm missing something?

@YalinLi0312
Copy link

We are not allowed to have any manual change in the generated source code now (here). I think either swagger or codgen tool has some problems.

@arpja
Copy link
Contributor Author

arpja commented Jan 20, 2021

Thanks @YalinLi0312
how do I get help with generated code failing to compile?

@arpja arpja closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants