-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[EngSys] make internal dev dependency versions consistent #36756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR standardizes internal development dependency version specifiers across the Azure SDK for JavaScript monorepo to ensure consistency in dependency management. The changes enforce the use of workspace:^ for internal workspace packages and catalog: references for cataloged dependencies, replacing inconsistent patterns like ^1.0.0 and workspace:*.
Key Changes
- Standardized workspace dependency version specifiers from
workspace:*toworkspace:^for better semantic versioning - Converted hardcoded versions to workspace references for internal tools (
@azure-tools/vite-plugin-browser-test-map) - Unified ARM package references to use the
catalog:armpattern (@azure/arm-resources)
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added @azure/arm-resources to the arm catalog for centralized version management |
| pnpm-lock.yaml | Automatic lockfile updates reflecting package.json changes across workspace |
| sdk/test-utils/recorder/package.json | Updated vite plugin and README documentation to use workspace references |
| sdk/test-utils/recorder/README.md | Updated example documentation to reflect workspace dependency pattern |
| sdk/subscription/arm-subscriptions/package.json | Standardized all workspace dependencies from workspace:* to workspace:^ |
| sdk/servicebus/service-bus/package.json | Converted vite plugin from hardcoded version to workspace reference |
| sdk/schemaregistry/schema-registry-json/package.json | Converted vite plugin from hardcoded version to workspace reference |
| sdk/schemaregistry/schema-registry-avro/package.json | Converted vite plugin from hardcoded version to workspace reference |
| sdk/mongocluster/arm-mongocluster/package.json | Standardized workspace dependencies from workspace:* to workspace:^ |
| sdk/links/arm-links/package.json | Changed arm-resources from hardcoded version to catalog reference |
| sdk/eventhub/eventhubs-checkpointstore-table/package.json | Converted vite plugin to workspace reference |
| sdk/eventhub/eventhubs-checkpointstore-blob/package.json | Converted vite plugin to workspace reference |
| sdk/eventhub/event-hubs/package.json | Converted vite plugin to workspace reference |
| sdk/documenttranslator/ai-document-translator-rest/package.json | Moved test-recorder from dependencies to devDependencies with workspace reference |
| sdk/deviceregistry/arm-deviceregistry/package.json | Standardized workspace dependencies from workspace:* to workspace:^ |
| sdk/dashboard/arm-dashboard/package.json | Standardized workspace dependencies from workspace:* to workspace:^ |
| sdk/core/ts-http-runtime/package.json | Converted vite plugin to workspace reference |
| sdk/core/core-sse/package.json | Converted vite plugin to workspace reference |
| sdk/core/core-rest-pipeline/package.json | Converted vite plugin to workspace reference |
| sdk/core/core-amqp/package.json | Converted vite plugin to workspace reference |
| sdk/containerregistry/arm-containerregistry/package.json | Standardized workspace dependencies from workspace:* to workspace:^ |
| sdk/communication/communication-call-automation/package.json | Converted vite plugin to workspace reference |
| sdk/batch/batch-rest/package.json | Changed arm-resources to catalog reference |
| sdk/ai/ai-voicelive/package.json | Standardized workspace dependencies from workspace:* to workspace:^ |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
with workspace and catalog version specifiers.
0713d51 to
0658cbd
Compare
with workspace and catalog version specifiers.