[storage]STG100 preview #36746

EmmaZhu · 2025-11-25T19:36:31Z

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

Checklists

Added impacted package name to the issue description
Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
Added a changelog (if necessary)

there are more than one possible design, why was the one in this PR chosen? request PRs)_ - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)

…Azure#34803) there are more than one possible design, why was the one in this PR chosen? request PRs)_ - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)

EmmaZhu · 2025-11-25T19:37:49Z

@jeremymeng , this PR changed API file and pnpm lock file. Could you help to review?

Copilot

Pull request overview

This pull request adds support for Azure Storage service version 2026-02-06 with User Delegation SAS functionality and Principal-Bound Identity User Delegation SAS across multiple storage packages (queue, file-share, and file-datalake). The changes include:

Service API version upgrade from 2025-11-05 to 2026-02-06
User delegation key support for generating SAS tokens using Azure AD tokens
New SAS parameters for user delegation (skoid, sktid, skt, ske, sks, skv, sduoid)
Principal-bound identity support via delegatedUserObjectId parameter
Generated code from updated Swagger specifications
Test coverage for new user delegation SAS functionality

Reviewed changes

Copilot reviewed 72 out of 110 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
sdk/storage/storage-queue/swagger/README.md	Updates Swagger input file to new API version and autorest version
sdk/storage/storage-queue/src/utils/constants.ts	Updates SDK and service version constants
sdk/storage/storage-queue/src/QueueServiceClient.ts	Adds getUserDelegationKey() method
sdk/storage/storage-queue/src/QueueClient.ts	Adds user delegation SAS generation methods
sdk/storage/storage-queue/src/SASQueryParameters.ts	Adds user delegation key fields and parameter serialization
sdk/storage/storage-queue/src/QueueSASSignatureValues.ts	Adds user delegation SAS generation logic with overloads
sdk/storage/storage-queue/test/node/sas.spec.ts	Adds test cases for user delegation SAS functionality
sdk/storage/storage-queue/test/utils/*	Adds test utility functions and new SAS parameters
sdk/storage/storage-file-share/*	Similar changes for file-share package
sdk/storage/storage-file-datalake/*	Version updates and test additions
sdk/storage/storage-queue/package.json	Updates version to 12.29.0-beta.1 and dependency

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

sdk/storage/storage-queue/test/node/sas.spec.ts

sdk/storage/storage-queue/src/QueueServiceClient.ts

sdk/storage/storage-queue/src/QueueSASSignatureValues.ts

sdk/storage/storage-file-share/src/ShareServiceClient.ts

sdk/storage/storage-file-share/src/FileSASSignatureValues.ts

sdk/storage/storage-queue/src/SASQueryParameters.ts

sdk/storage/storage-file-share/src/SASQueryParameters.ts

sdk/storage/storage-queue/src/QueueSASSignatureValues.ts

sdk/storage/storage-file-share/src/FileSASSignatureValues.ts

jeremymeng

Overall looks good! Minor question: are blob and file-datalake not using the UserDelegationKey from storage-common?

jeremymeng · 2025-11-25T20:00:40Z

sdk/storage/storage-file-share/review/storage-file-share-node.api.md

 import type { TokenCredential } from '@azure/core-auth';
 import type { TransferProgressEvent } from '@azure/core-rest-pipeline';
 import type { UserAgentPolicyOptions } from '@azure/core-rest-pipeline';
+import { UserDelegationKey as UserDelegationKey_2 } from '@azure/storage-common';


Is this because we still have another different UserDelegationKey in file-share? Do we need both?

jeremymeng · 2025-11-25T20:01:26Z

sdk/storage/storage-file-share/review/storage-file-share-node.api.md


 // @public
 export interface ShareProtocolSettings {
+    // Warning: (ae-forgotten-export) The symbol "ShareNfsSettings" needs to be exported by the entry point index.d.ts


Need to fix this warning.

jeremymeng · 2025-11-25T20:02:40Z

sdk/storage/storage-file-share/review/storage-file-share-node.api.md


 // @public
 export interface ShareSmbSettings {
+    // Warning: (ae-forgotten-export) The symbol "ShareSmbSettingsEncryptionInTransit" needs to be exported by the entry point index.d.ts


Need to fix this warning.

jeremymeng · 2025-11-25T20:05:31Z

sdk/storage/storage-queue/review/storage-queue-node.api.md

 import { StorageSharedKeyCredentialPolicy } from '@azure/storage-common';
 import type { TokenCredential } from '@azure/core-auth';
 import type { UserAgentPolicyOptions } from '@azure/core-rest-pipeline';
+import { UserDelegationKey as UserDelegationKey_2 } from '@azure/storage-common';


same question as the one for file-share.

github-actions · 2025-11-26T06:34:17Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/storage-blob
@azure/storage-common
@azure/storage-file-datalake
@azure/storage-file-share
@azure/storage-queue

sdk/storage/storage-file-share/review/storage-file-share-node.api.md

sdk/storage/storage-file-share/src/Clients.ts

jeremymeng · 2025-11-26T17:01:18Z

sdk/storage/storage-file-share/review/storage-file-share-node.api.md


+// @public
+export interface ShareNfsSettings {
+    // Warning: (ae-forgotten-export) The symbol "ShareNfsSettingsEncryptionInTransit" needs to be exported by the entry point index.d.ts


This warning still needs fix.

blueww

LGTM

EmmaZhu added 16 commits November 19, 2025 10:41

Security Principal Bound Identity SAS

84ef963

StartFrom

decc8a1

Datalake

feeb1de

Record test cases

fb1cade

Format

2d2e058

Update to published swagger

e8d1c5c

[Storage] File user delegation key&sas

fab329f

User delegation key and delegation SAS

8faeb0c

[storage]Making SMB Directory leases configurable on a share level

731f636

Files Encryption in Transit API support

d11f027

Create file with data

18abefc

File create with data

56f05ed

Queue user delegation key and SAS

e696711

Record test cases

55c4934

Copilot AI review requested due to automatic review settings November 25, 2025 19:36

EmmaZhu requested review from a team, XiaoningLiu, blueww, jeremymeng, jiacfan, ljian3377 and vinjiang as code owners November 25, 2025 19:36

github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Nov 25, 2025

Copilot started reviewing on behalf of EmmaZhu November 25, 2025 19:37 View session

Copilot finished reviewing on behalf of EmmaZhu November 25, 2025 19:38

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Fix format issue

92965fd

jeremymeng reviewed Nov 25, 2025

View reviewed changes

Resolve comments

688b5db

EmmaZhu force-pushed the stg100_file branch from 0ad9af8 to 688b5db Compare November 26, 2025 06:24

blueww reviewed Nov 26, 2025

View reviewed changes

sdk/storage/storage-file-share/review/storage-file-share-node.api.md Outdated Show resolved Hide resolved

blueww reviewed Nov 26, 2025

View reviewed changes

sdk/storage/storage-file-share/review/storage-file-share-node.api.md Outdated Show resolved Hide resolved

blueww reviewed Nov 26, 2025

View reviewed changes

sdk/storage/storage-file-share/review/storage-file-share-node.api.md Outdated Show resolved Hide resolved

blueww reviewed Nov 26, 2025

View reviewed changes

sdk/storage/storage-file-share/review/storage-file-share-node.api.md Outdated Show resolved Hide resolved

blueww reviewed Nov 26, 2025

View reviewed changes

sdk/storage/storage-file-share/src/Clients.ts Outdated Show resolved Hide resolved

Resolve comments

16e6f4d

EmmaZhu force-pushed the stg100_file branch from 324b8d1 to 16e6f4d Compare November 26, 2025 09:02

blueww approved these changes Nov 26, 2025

View reviewed changes

Format

93a0709

blueww approved these changes Nov 26, 2025

View reviewed changes

jeremymeng reviewed Nov 26, 2025

View reviewed changes

Resolve comments

05c3200

blueww approved these changes Nov 27, 2025

View reviewed changes

[storage]STG100 preview #36746

Are you sure you want to change the base?

[storage]STG100 preview #36746

Uh oh!

Conversation

EmmaZhu commented Nov 25, 2025

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

Uh oh!

EmmaZhu commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremymeng left a comment

Choose a reason for hiding this comment

Uh oh!

jeremymeng Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

jeremymeng Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

jeremymeng Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

jeremymeng Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremymeng Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

blueww left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

github-actions bot commented Nov 26, 2025 •

edited

Loading