Skip to content

Change client retrieval to use Azure OpenAI client #36722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change client retrieval to use Azure OpenAI client #36722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/ai/ai-projects/samples/v2-beta/typescript/src/agents/agentBasic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const deploymentName = process.env["MODEL_DEPLOYMENT_NAME"] || "<model deploymen
export async function main(): Promise<void> {
// Create AI Project client
const project = new AIProjectClient(projectEndpoint, new DefaultAzureCredential());
const openAIClient = await project.getOpenAIClient();
const openAIClient = await project.getAzureOpenAIClient();
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a bug. The AIProjectClient class does not have a getAzureOpenAIClient() method. The correct method is getOpenAIClient(), which is defined in sdk/ai/ai-projects/src/aiProjectClient.ts at line 127.

Other samples in the same directory (e.g., agentCodeInterpreter.ts, agentFunctionTool.ts) correctly use getOpenAIClient(). This change should be reverted to use await project.getOpenAIClient() instead.

Suggested change
const openAIClient = await project.getAzureOpenAIClient();
const openAIClient = await project.getOpenAIClient();

Copilot uses AI. Check for mistakes.

// Create agent
console.log("Creating agent...");
Expand Down
Loading