Skip to content

Fix incomplete abort signal handling in memory store update poller #36710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2025
Merged

Fix incomplete abort signal handling in memory store update poller #36710

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6402bb5
Initial plan
Copilot Nov 20, 2025
475cdc8
Fix abort signal handling in memoryStoreUpdatePoller
Copilot Nov 20, 2025
b95f0ea
Merge branch 'glharper/proj-mem-store-update' into copilot/sub-pr-367…
glharper Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdk/ai/ai-projects/src/api/memoryStores/memoryStoreUpdatePoller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ function applyUpdateState(
function buildRunningOperation(
client: Client,
expectedStatuses: string[],
options: CreateMemoryStoreUpdatePollerOptions,
getInitialResponse?: () => PromiseLike<PathUncheckedResponse>,
options?: CreateMemoryStoreUpdatePollerOptions,
): RunningOperation<PathUncheckedResponse> {
Expand All @@ -152,12 +153,12 @@ function buildRunningOperation(
pollAbortController.abort();
}
const abortSignal = pollAbortController.signal;
if (options?.abortSignal?.aborted) {
if (options.abortSignal?.aborted) {
pollAbortController.abort();
} else if (pollOptions?.abortSignal?.aborted) {
pollAbortController.abort();
} else if (!abortSignal.aborted) {
options?.abortSignal?.addEventListener("abort", abortListener, {
options.abortSignal?.addEventListener("abort", abortListener, {
once: true,
});
pollOptions?.abortSignal?.addEventListener("abort", abortListener, {
Expand All @@ -169,7 +170,7 @@ function buildRunningOperation(
try {
response = (await client.pathUnchecked(path).get({ abortSignal })) as PathUncheckedResponse;
} finally {
options?.abortSignal?.removeEventListener("abort", abortListener);
options.abortSignal?.removeEventListener("abort", abortListener);
pollOptions?.abortSignal?.removeEventListener("abort", abortListener);
}

Expand All @@ -193,6 +194,7 @@ export function createMemoryStoreUpdatePoller(
buildRunningOperation(
client,
expectedStatuses,
options,
getInitialResponse
? async () => {
initialResponse = await getInitialResponse();
Expand Down