Internal: Refactoring Spark connector build as preparation for adding dual sca 2.12 and 2.13 compilation in subsequent PR #47069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a 2.12 and 2.13 compilation in subsequent PR
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
FabianMeiswinkel
requested review from
Copilot
and removed request for
Copilot
FabianMeiswinkel
requested review from
a team and
kirankumarkolli
as code owners
|
/azp run java - cosmos - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - cosmos - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Spark connector build structure to prepare for dual-compilation support for Scala 2.12 and 2.13. The changes reorganize the module hierarchy by removing Scala version suffixes from shared source artifacts and introducing intermediary pom-packaging projects for version-specific builds.
Key Changes:
- Renamed
azure-cosmos-spark_3_2-12toazure-cosmos-spark_3(shared source, no Scala version suffix) - Added intermediary pom-packaging project
azure-cosmos-spark_3-5for Spark 3.5 - Updated all child projects to reference the renamed parent modules
Reviewed Changes
Copilot reviewed 13 out of 278 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/pom.xml | Updated module list to include new azure-cosmos-spark_3 and azure-cosmos-spark_3-5 modules |
| sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/SparkBridgeInternal.scala | Added blank line for formatting consistency |
| sdk/cosmos/azure-cosmos-spark_3_2-12/pom.xml | Renamed artifact from azure-cosmos-spark_3_2-12 to azure-cosmos-spark_3 with version change |
| sdk/cosmos/azure-cosmos-spark_3_2-12/CHANGELOG.md | Updated version number to reflect new artifact versioning |
| sdk/cosmos/azure-cosmos-spark_3/CHANGELOG.md | Added CHANGELOG for new shared source module |
| sdk/cosmos/azure-cosmos-spark_3-5_2-12/pom.xml | Updated parent reference and removed duplicate build configuration |
| sdk/cosmos/azure-cosmos-spark_3-5/scalastyle_config.xml | Added Scalastyle configuration for new intermediary module |
| sdk/cosmos/azure-cosmos-spark_3-5/pom.xml | Added new intermediary pom with build configuration and dependencies |
| sdk/cosmos/azure-cosmos-spark_3-5/README.md | Added README for new module |
| sdk/cosmos/azure-cosmos-spark_3-5/CONTRIBUTING.md | Added contribution guidelines for new module |
| sdk/cosmos/azure-cosmos-spark_3-4_2-12/pom.xml | Updated parent references to new shared source module |
| sdk/cosmos/azure-cosmos-spark_3-3_2-12/pom.xml | Updated parent references to new shared source module |
| eng/versioning/version_client.txt | Added version entries for new artifacts |
Co-authored-by: Copilot <[email protected]>
|
/azp run java - cosmos - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
…://github.com/FabianMeiswinkel/azure-sdk-for-java into users/fabianm/SparkRefactoringDualCompilation
|
/azp run java - cosmos - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This reverts commit b8d3cf9.
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - kafka |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
requested review from
moarychan and
saragluna
as code owners
…to users/fabianm/SparkRefactoringDualCompilation
…to users/fabianm/SparkRefactoringDualCompilation
…to users/fabianm/SparkRefactoringDualCompilation
|
/azp run java - cosmos - spark |
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - kafka |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
tvaron3
reviewed
Oct 23, 2025
g2vinay
reviewed
Oct 23, 2025
g2vinay
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies build of Spark Connector to allow adding dual-compilation for scala 2.12 and 2.13 later.
Removes the scala version suffix from artifacts for the shared source project (now azure-cosmos-spark_3)
Adds an intermediary pom-packaging project for Spark 3-5 - to later allow having to children for azure-cosmos-spark_3-5_2-12 and azure-cosmos-spark_3-5_2-13
This is just preparation work for adding sclaa 2.13 to reduce the noise in the second PR - and make reviews easier.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines