Support stable code.* attributes
#47064
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
a team,
harsimar,
jeanbisutti,
rajkumar-rangaraj,
ramthi and
xiang17
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for stable code.* attributes from the OpenTelemetry semantic conventions, while maintaining backward compatibility with the incubating attributes. The changes map the new stable code attributes (code.file.path, code.function, code.lineno) to Azure Monitor properties alongside the existing incubating attributes.
- Adds support for stable
code.*semantic convention attributes - Implements mapping logic to extract class name and method name from
code.function - Adds comprehensive test coverage for the new stable attributes and edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LogDataMapper.java | Adds mapping for stable code attributes and implements function name parsing logic |
| LogDataMapperTest.java | Adds test coverage for stable attributes, incubating attributes compatibility, and edge cases |
.../com/azure/monitor/opentelemetry/autoconfigure/implementation/logging/LogDataMapperTest.java
Show resolved
Hide resolved
github-actions
bot
added
the
Monitor - Autoconfigure
trask
force-pushed
the
stable-code-attrs
branch
from
9c59040 to
9aecef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/semantic-conventions#2955
TODO test this PR using Java agent