-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Idickers/2025-11-01-preview-sdk-gen-java #47057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@idickerson7 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
...earch/azure-search-documents/src/main/java/com/azure/search/documents/SearchAsyncClient.java
Show resolved
Hide resolved
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * Parameters for Azure Blob Storage knowledge source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description seems off, but this is also coming from the Swagger. Should make sure the model in Swagger has the right description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Says the same thing in searchservice.json, so I guess a mistake on that end?
...h-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexerStatus.java
Outdated
Show resolved
Hide resolved
...cuments/src/main/java/com/azure/search/documents/indexes/models/SearchServiceStatistics.java
Outdated
Show resolved
Hide resolved
| // Changes may cause incorrect behavior and will be lost if the code is regenerated. | ||
|
|
||
| package com.azure.search.documents.agents.implementation; | ||
| package com.azure.search.documents.knowledgebases.implementation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should target the package knowledge rather than knowledgebases to make this more flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. The SDK-V team agreed to change namespaces from .agent to .knowledgebases across the repo, but this is something I could bring up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be deleted, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've yet to deal with the renaming of the tests and related test files
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines