Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identity V2 Credentials #44736

Merged
merged 17 commits into from
Mar 25, 2025
Merged

Add Identity V2 Credentials #44736

merged 17 commits into from
Mar 25, 2025

Conversation

g2vinay
Copy link
Member

@g2vinay g2vinay commented Mar 20, 2025

No description provided.

@g2vinay
Copy link
Member Author

g2vinay commented Mar 20, 2025

pushing unit tests in next commit.

@g2vinay g2vinay requested a review from billwert March 20, 2025 21:11
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 24, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.v2:azure-identity-v2

@g2vinay g2vinay marked this pull request as ready for review March 24, 2025 19:56
@g2vinay g2vinay requested review from joshfree and a team as code owners March 24, 2025 19:56
srnagar
srnagar reviewed Mar 24, 2025
View reviewed changes
billwert
billwert requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several general cleanup comments.

srnagar
srnagar approved these changes Mar 25, 2025
View reviewed changes
billwert
billwert approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall! Thank you!

@g2vinay g2vinay merged commit 4f28475 into Azure:main Mar 25, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft left review comments

@billwert billwert billwert approved these changes

@srnagar srnagar srnagar approved these changes

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@g2vinay @azure-sdk @billwert @alzimmermsft @srnagar