Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rest proxy code and move shared test to annotation-processor-test #44660

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Remove rest proxy code and move shared test to annotation-processor-test #44660

wants to merge 5 commits into from

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Mar 14, 2025 •
edited
Loading

Description

  • RestProxyTests are now TestInterfaceGenerationTests
  • RestProxyImplTests also moved to TestInterfaceGenerationTests, omitting body length validating tests.
    -RestProxyXmlSerializableTests moved to XmlSerializableTests

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@samvaity samvaity self-assigned this Mar 14, 2025
@samvaity samvaity force-pushed the remove-rest-files branch 2 times, most recently from f625573 to a610b55 Compare March 19, 2025 17:52
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 20, 2025 •
edited
Loading

API change check

API changes are not detected in this pull request.

@samvaity samvaity force-pushed the remove-rest-files branch 10 times, most recently from 8fb0741 to a45d212 Compare March 20, 2025 21:40
@samvaity samvaity force-pushed the remove-rest-files branch from d4d0101 to ca5a14b Compare March 25, 2025 08:50
@samvaity samvaity force-pushed the remove-rest-files branch from ca5a14b to 5bbd893 Compare March 25, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 will be requested when the pull request is marked ready for review vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft will be requested when the pull request is marked ready for review alzimmermsft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@samvaity samvaity

Labels
clientcore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samvaity @azure-sdk